-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Template): add release branch support #5534
Conversation
Reviewer's Guide by SourceryThis pull request includes changes to the GitHub workflow and pull request template files. The pull request template was updated to provide clearer instructions for linking issues. The workflow files were updated to include the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a matrix strategy in your workflows to avoid repetition for similar jobs triggered by different branches.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5534 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29607 29607
Branches 4173 4173
=========================================
Hits 29607 29607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
[请在下方 # 后面填写相关 Issue 编号,如 #42]
close #5533
Summary By Copilot
This pull request includes changes to the GitHub workflow and pull request template files to improve clarity and functionality. The most important changes include modifications to the pull request template for better instructions and updates to the workflow files to include additional branches.
Improvements to pull request template:
.github/pull_request_template.md
: Updated the instructions for linking issues to be clearer and more user-friendly. [1] [2]Updates to workflow files:
.github/workflows/docker.yml
: Added therelease
branch to the list of branches that trigger the workflow..github/workflows/pack.yml
: Added therelease
branch to the list of branches that trigger the workflow.Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge