Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Template): add release branch support #5534

Merged
merged 3 commits into from
Mar 6, 2025
Merged

chore(Template): add release branch support #5534

merged 3 commits into from
Mar 6, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Mar 6, 2025

Link issues

[请在下方 # 后面填写相关 Issue 编号,如 #42]
close #5533

Summary By Copilot

This pull request includes changes to the GitHub workflow and pull request template files to improve clarity and functionality. The most important changes include modifications to the pull request template for better instructions and updates to the workflow files to include additional branches.

Improvements to pull request template:

Updates to workflow files:

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

@bb-auto bb-auto bot added documentation Improvements or additions to documentation Welcome PR Extra attention is needed labels Mar 6, 2025
Copy link

sourcery-ai bot commented Mar 6, 2025

Reviewer's Guide by Sourcery

This pull request includes changes to the GitHub workflow and pull request template files. The pull request template was updated to provide clearer instructions for linking issues. The workflow files were updated to include the release branch as a trigger.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The pull request template was updated to provide clearer instructions for linking issues.
  • Updated the instructions for linking issues to be clearer and more user-friendly.
  • Added translations for linking issues instructions.
.github/pull_request_template.md
The workflow files were updated to include the release branch as a trigger.
  • Added the release branch to the list of branches that trigger the workflow.
.github/workflows/docker.yml
.github/workflows/pack.yml

Possibly linked issues

  • #0: The PR adds release branch support to the template files, addressing the issue of missing release branch support.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the V7.0.0 milestone Mar 6, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a matrix strategy in your workflows to avoid repetition for similar jobs triggered by different branches.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e54e37b) to head (cc47ddb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5534   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          649       649           
  Lines        29607     29607           
  Branches      4173      4173           
=========================================
  Hits         29607     29607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bb-auto bb-auto bot added chore This are tasks or bot action and removed documentation Improvements or additions to documentation Welcome PR Extra attention is needed labels Mar 6, 2025
@bb-auto bb-auto bot modified the milestones: V7.0.0, v9.4.0 Mar 6, 2025
@ArgoZhang ArgoZhang merged commit 247e186 into main Mar 6, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the chore-config branch March 6, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This are tasks or bot action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(Template): add release branch support
1 participant