-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(Layout): remove man z-index attribute #5540
Conversation
Reviewer's Guide by SourceryThis pull request simplifies the layout styles by removing the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why these properties are being removed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5540 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29607 29607
Branches 4173 4173
=========================================
Hits 29607 29607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…5595) * Revert "doc(Layout): remove man z-index attribute (#5540)" This reverts commit 096dc3f. * refactor: 移除 InvokeAsync 包裹 * refactor: 支持多个 provider 逻辑 * refactor: 使用 BootstrapBlazorRootContent 更改位置 * refactor: 重构 Swal 组件 * refactor: 更新文档注释 * doc: 更新文档注释 * refactor: 增加扩展属性 * style: 增加样式防止多层弹窗导致背景色加深 * refactor(Swal): 增加 swal 样式 * test: 更新单元测试 * test: 更新单元测试 * test: 更新单元测试 * test: 更新单元测试
Link issues
fixes #5539
[Please fill in the relevant Issue number after the # above, such as #42]
[请在上方 # 后面填写相关 Issue 编号,如 #42]
Summary By Copilot
This pull request includes changes to the CSS files for the
BaseLayout
andMainLayout
components in theBootstrapBlazor.Server
project. The changes focus on simplifying the layout styles by removing unnecessary CSS properties.Simplification of layout styles:
src/BootstrapBlazor.Server/Components/Layout/BaseLayout.razor.css
: Removedposition: relative;
andz-index: 10;
from themain
element.src/BootstrapBlazor.Server/Components/Layout/MainLayout.razor.css
: Removedposition: relative;
andz-index: 5;
from the.main
class.Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: