-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Modal): keep document original style #5542
Conversation
Reviewer's Guide by SourceryThis pull request includes updates to the version number in the Sequence diagram for hiding the modalsequenceDiagram
participant document
participant modal
document->>modal: modal.hide()
activate modal
modal->>document: modal.modal.hide()
modal->>document: document.body.style = modal.originalStyle
modal->>document: modal.originalStyle = null
deactivate modal
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a try-finally block in
modal.show
andmodal.hide
to ensure the original style is always restored, even if errors occur.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5542 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29607 29607
Branches 4173 4173
=========================================
Hits 29607 29607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5541
[Please fill in the relevant Issue number after the # above, such as #42]
[请在上方 # 后面填写相关 Issue 编号,如 #42]
Summary By Copilot
This pull request includes updates to the version number in the
BootstrapBlazor.csproj
file and enhancements to the modal component's JavaScript functionality inModal.razor.js
. The most important changes focus on preserving and restoring the original body style when modals are shown and hidden.Version Update:
src/BootstrapBlazor/BootstrapBlazor.csproj
: Updated version from9.4.7-beta02
to9.4.7-beta03
.Modal Component Enhancements:
src/BootstrapBlazor/Components/Modal/Modal.razor.js
: AddedoriginalStyle
property to the modal object to store the original body style.src/BootstrapBlazor/Components/Modal/Modal.razor.js
: Modified themodal.show
function to save the original body style before applying modal-specific styles.src/BootstrapBlazor/Components/Modal/Modal.razor.js
: Updated themodal.hide
function to restore the original body style after hiding the modal.src/BootstrapBlazor/Components/Modal/Modal.razor.js
: Ensured the original body style is restored when the modal is disposed.Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Preserve and restore the original body style when modals are shown and hidden, and update the version number.
Enhancements: