-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(SourceCodePath): add SourceCodePath configuration section #5602
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment to explain why the
SourceCodePath
is configurable.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5602 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29625 29625
Branches 4165 4165
=========================================
Hits 29625 29625 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5601
Summary By Copilot
This pull request includes several changes to the
CodeSnippetService
class in theBootstrapBlazor.Server
project. The most important changes involve adding a new dependency, modifying the logic for determining the source code path, and introducing a helper method to retrieve this path.Dependency addition:
src/BootstrapBlazor.Server/Services/CodeSnippetService.cs
: AddedIConfiguration
as a new parameter to theCodeSnippetService
constructor to allow configuration settings to be injected.Source code path logic improvement:
src/BootstrapBlazor.Server/Services/CodeSnippetService.cs
: Modified the logic inReadFileAsync
to use the newGetSourceCodePath
method instead of directly accessingoptions.Value.SourceCodePath
.src/BootstrapBlazor.Server/Services/CodeSnippetService.cs
: Introduced a new private methodGetSourceCodePath
to retrieve the source code path from the configuration or fallback to the options value.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: