Skip to content

Commit

Permalink
Remove the config->podcasts->name validation
Browse files Browse the repository at this point in the history
  • Loading branch information
dplocki committed Mar 10, 2024
1 parent 8d8d4e7 commit a78253b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
3 changes: 0 additions & 3 deletions podcast_downloader/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@

def configuration_verification(config: dict) -> Tuple[bool, List[str]]:
for podcast in config[CONFIG_PODCASTS]:
if not CONFIG_PODCASTS_NAME in podcast:
return False, "Name is missing for one of the podcast"

if not CONFIG_PODCASTS_PATH in podcast:
return (
False,
Expand Down
13 changes: 0 additions & 13 deletions tests/configuration_verification_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,6 @@


class TestConfigurationVerification(unittest.TestCase):
def test_check_for_name_in_podcast_subgroup(self):
# Assign
config = {configuration.CONFIG_PODCASTS: [{}]}

# Act
is_valid_result, message = configuration.configuration_verification(config)

# Assert
self.assertFalse(
is_valid_result, "Validator should notice missing 'name' field in podcast"
)
self.assertIsNotNone(message, "The validator should return message")

def test_check_for_path_in_podcast_subgroup(self):
# Assign
config = {
Expand Down

0 comments on commit a78253b

Please sign in to comment.