Skip to content

Commit

Permalink
update readme
Browse files Browse the repository at this point in the history
  • Loading branch information
dragoon committed Nov 21, 2023
1 parent 102d563 commit 46bb334
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -295,18 +295,18 @@ This is clearly visible when we plot the total number of bids/asks for any asset

For very liquid assets like BTC, order book can contain many more bids and asks then initial 5000 allowed by _Binance_.
So actually we don't want to refresh our order book cache at all unless there is an exception.
After fixing the issue with refresh interval, the chart looks reasonable like this:
After fixing the issue with refresh interval, the chart looks correct like this:

![](assets/refresh_interval_fixed.png)

#### Limit
The ``limit`` parameter sets the initial amount of orders to retrieve from the order book.
Ideally, we want to retrieve the full order book on startup, and not have this parameter at all,
but _Binance API_ imposes this limit. The only reason for making it lower than maximum 5000 is because
Binance API has a complex system of API request limits based on the weight of the actual call,
but in case of websockets this is not applicable.
but _Binance API_ imposes this limit. I don't see any reason for making this lower than maximum 5000.
As we said, order book can contain many more bids and ask than top 5000, and we only receive updates to the order book
after we started our data collector, so it make date some time until you have full order book.

For the sake of comparison, here are the graphs of total number of asks and bids for Bitcoin using starting values of 5000 and 100 for limit:
For example, here are the graphs of total number of asks and bids for Bitcoin using starting values of 5000 and 100 for limit:



Expand Down

1 comment on commit 46bb334

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
start_data_collector.py25250%1–33
datacollector
   domain.py280100% 
datacollector/repositories
   data_repository.py60100% 
datacollector/services
   collector_service.py671184%17, 20–34
   data_process_service.py400100% 
   datetime_service.py9189%13
TOTAL1753779% 

Tests Skipped Failures Errors Time
6 0 💤 0 ❌ 0 🔥 1.257s ⏱️

Please sign in to comment.