Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dead_code compile error #328

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

newAM
Copy link
Contributor

@newAM newAM commented Apr 20, 2024

What does this PR accomplish?

  • 🩹 Bug Fix

Changes proposed by this PR:

Rust 1.77 merged unused_tuple_struct_fields into dead_code, which resulted in the build failing because #![deny(dead_code)] is set in src/lib.rs.

Notes to reviewer:

📜 Checklist

  • Works on the ./demo sub directory
  • Test coverage is excellent and passes
  • Documentation is thorough

@drahnr
Copy link
Owner

drahnr commented Apr 21, 2024

Hey @newAM , thank you for the PR!

I think CommonLang can either be removed entirely (my preference, from a quick glance shouldn't be used anywhere anyways) or annotated with an allow(dead_deadcode) exception. I don't think the current approach is the right way.

@matthiasbeyer I don't think we're aligned on the quality bar for cargo-spellcheck :)

Removes the unused CommonLang type.
@newAM newAM force-pushed the fix-dead-code-error branch from 418a1e1 to 189eefe Compare April 21, 2024 22:04
@newAM
Copy link
Contributor Author

newAM commented Apr 21, 2024

Sounds good, I removed the CommonLang type!

@drahnr drahnr merged commit 25ebbd9 into drahnr:master Apr 22, 2024
8 checks passed
@newAM newAM deleted the fix-dead-code-error branch April 22, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants