Common pool calculations file #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergerad
reviewed
Nov 3, 2024
| let val: f64 = 1.0001; | ||
|
|
||
| if token_one_decimals != token_two_decimals { | ||
| println!("Exchange when token decimals not the same not yet supported"); |
There was a problem hiding this comment.
This should return an error (anyhow!()) and then anything that uses the fn can choose to print the error or return it etc
sergerad
reviewed
Nov 3, 2024
| @@ -0,0 +1,17 @@ | |||
| use uniswap_v3_sdk::prelude::FeeAmount; | |||
|
|
|||
| pub fn fee_to_float(fee: FeeAmount) -> f32 { | |||
There was a problem hiding this comment.
Why does this need to be a float?
There was a problem hiding this comment.
Because the result can be 0.01, for instance. Though the current usage of the result is as a string, it is likely that the result will be used in calculations of the cost of doing a price change.
tsnewnami
approved these changes
Nov 3, 2024
Handle error, underflow and denominator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a file with common pool calculations:
The tick to exchange rate calculation currently does not handle decimals for the tokens being different.