Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: styles in signup page , footer and headings #14

Merged
merged 31 commits into from
Mar 11, 2024
Merged

fix: styles in signup page , footer and headings #14

merged 31 commits into from
Mar 11, 2024

Conversation

Srish-ty
Copy link
Member

No description provided.

@Srish-ty Srish-ty marked this pull request as ready for review February 11, 2024 13:51
@Shurtu-gal Shurtu-gal self-requested a review February 16, 2024 06:00
Shurtu-gal
Shurtu-gal reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Srish-ty Input boxes size can be increased.

@Srish-ty
Copy link
Member Author

@Srish-ty Input boxes size can be increased.

It was showing fine, but after merging new commits from origin, it's height has changed

@vercel Vercel
Copy link

vercel bot commented Feb 16, 2024

@Srish-ty is attempting to deploy a commit to the dscnitrourkela Team on Vercel.

A member of the Team first needs to authorize it.

@Srish-ty
Copy link
Member Author

@Shurtu-gal , @ashutosh-rath02 please review

@vercel Vercel
Copy link

vercel bot commented Feb 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-ticket ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 5:42pm

Shurtu-gal
Shurtu-gal requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Srish-ty Build is failing

@Srish-ty
Copy link
Member Author

@Srish-ty Build is failing

I'm able to build locally

@Srish-ty
Copy link
Member Author

@Shurtu-gal , @ashutosh-rath02 please review

Shurtu-gal
Shurtu-gal requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Some solution such as ellipsis or sth else.

image

  • The close icon is still not good, it can be made smaller and put on corner of modal.
  • Clicking on backdrop should close the modal
  • The team name is getting cut.

@Srish-ty
Copy link
Member Author

Srish-ty commented Mar 4, 2024

image Some solution such as ellipsis or sth else.

image

  • The close icon is still not good, it can be made smaller and put on corner of modal.
  • Clicking on backdrop should close the modal
  • The team name is getting cut.

Fixed that styling. commited changes

@Srish-ty
Copy link
Member Author

Srish-ty commented Mar 4, 2024 •
edited
Loading

fixed preview for sharing on socials.

commit link
image

Shurtu-gal
Shurtu-gal reviewed Mar 4, 2024
View reviewed changes
src/app/preview/[slug]/opengraph-image.tsx Outdated
<span style={{ ...ticketNumStyle } as React.CSSProperties}>{ticketId || '550000'}</span>
</div>
</div>
<InnerTicket
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this working ?
Because I had tried this and it wasn't working.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've changed the code.
And now the preview is visible, I'd attached the screenshot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not for that. The link for this goes like http://localhost:3000/preview/B0uHy0AIhcQWVv768GLl8auhXBm2/opengraph-image. And is used for of image generation.

@vercel/og does not support the components written before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. commit

Shurtu-gal
Shurtu-gal approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪨

@Shurtu-gal Shurtu-gal merged commit 3e517fd into dscnitrourkela:main Mar 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shurtu-gal Shurtu-gal Shurtu-gal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Srish-ty @Shurtu-gal @ashutosh-rath02