Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VST dynamic parameter support #243

Open
wants to merge 4 commits into
base: dynamic-parameters
Choose a base branch
from
Open

VST dynamic parameter support #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
599e0cc
Update VST for dynamic parameters
mikeoliphant Dec 18, 2024
d702e14
Merge branch 'dynamic-parameters' of https://github.com/mikeoliphant/…
mikeoliphant Dec 18, 2024
3417b88
Merge branch 'dsharlet:dynamic-parameters' into dynamic-parameters
mikeoliphant Dec 20, 2024
0bf49c1
Added shared CircuitSimlation class. Fixed VST parameter mapping.
mikeoliphant Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions Circuit/CircuitSimulation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
using System;
using System.Collections.Generic;
using System.Drawing;
using System.Linq;
using System.Linq.Expressions;
using Util;

namespace Circuit
{
public class CircuitSimulation
{
public Schematic Schematic { get; private set; }
public Circuit Circuit { get; private set; }
public Analysis Analysis { get; private set; }
public Simulation Simulation { get; private set; } = null;
public ILog Log { get; private set; }
public int Oversample { get; set; } = 8;
public int Iterations { get; set; } = 8;
public double SampleRate { get; set; } = 48000;
public bool HaveSimulation { get { return Simulation != null; } }

Dictionary<ComputerAlgebra.Expression, int> argumentLookup = new Dictionary<ComputerAlgebra.Expression, int>();
double[] arguments;

public CircuitSimulation(Schematic schematic, ILog log)
{
Schematic = schematic;
Log = log;

Circuit = Schematic.Build(Log);
Analysis = Circuit.Analyze();

arguments = new double[Analysis.Parameters.Count()];

int pos = 0;

foreach (Analysis.Parameter P in Analysis.Parameters)
{
arguments[pos] = P.Value;
argumentLookup[P.Expression] = pos++;
}
}

public void SetParameter(ComputerAlgebra.Expression expression, double value)
{
arguments[argumentLookup[expression]] = value;
}

public void UpdateSimulation(IEnumerable<ComputerAlgebra.Expression> inputs, IEnumerable<ComputerAlgebra.Expression> outputs)
{
ComputerAlgebra.Expression h = (ComputerAlgebra.Expression)1 / (SampleRate * Oversample);
TransientSolution solution = TransientSolution.Solve(Circuit.Analyze(), h, Log);

var newSimulation = new Simulation(solution)
{
Log = Log,
Input = inputs,
Output = outputs,
Arguments = Analysis.Parameters.Select(p => p.Expression),
Oversample = Oversample,
Iterations = Iterations,
};

Simulation = newSimulation;
}

public void RunSimulation(int numSamples, IEnumerable<double[]> audioInputs, IEnumerable<double[]> audioOutputs)
{
Simulation.Run(numSamples, audioInputs, audioOutputs, arguments);
}
}
}
127 changes: 36 additions & 91 deletions LiveSPICE/LiveSimulation.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ partial class LiveSimulation : Window, INotifyPropertyChanged
/// </summary>
public int Oversample
{
get { return oversample; }
set { oversample = Math.Max(1, value); RebuildSolution(); NotifyChanged(nameof(Oversample)); }
get { return circuitSimulation.Oversample; }
set { circuitSimulation.Oversample = Math.Max(1, value); RebuildSolution(); NotifyChanged(nameof(Oversample)); }
}

protected int iterations = 8;
Expand All @@ -44,8 +44,8 @@ public int Oversample
/// </summary>
public int Iterations
{
get { return iterations; }
set { iterations = Math.Max(1, value); RebuildSolution(); NotifyChanged(nameof(Iterations)); }
get { return circuitSimulation.Iterations; }
set { circuitSimulation.Iterations = Math.Max(1, value); RebuildSolution(); NotifyChanged(nameof(Iterations)); }
}

private double inputGain = 1.0;
Expand All @@ -62,13 +62,7 @@ public int Iterations

private SimulationSchematic Schematic { get { return (SimulationSchematic)schematic.Schematic; } set { schematic.Schematic = value; } }

protected Circuit.Circuit circuit = null;
protected Simulation simulation = null;

private List<Probe> probes = new List<Probe>();
protected Dictionary<ComputerAlgebra.Expression, double> namedArguments = new Dictionary<ComputerAlgebra.Expression, double>();

private object sync = new object();

protected Audio.Stream stream = null;

Expand All @@ -82,6 +76,8 @@ public int Iterations
// A timer for continuously refreshing controls.
protected System.Timers.Timer timer;

CircuitSimulation circuitSimulation;

public LiveSimulation(Schematic Simulate, Audio.Device Device, Audio.Channel[] Inputs, Audio.Channel[] Outputs)
{
try
Expand All @@ -96,14 +92,10 @@ public LiveSimulation(Schematic Simulate, Audio.Device Device, Audio.Channel[] I
Schematic = new SimulationSchematic(clone);
Schematic.SelectionChanged += OnProbeSelected;

// Build the circuit from the schematic.
circuit = Schematic.Schematic.Build(Log);
Circuit.Analysis analysis = circuit.Analyze();
circuitSimulation = new CircuitSimulation(Schematic.Schematic, Log);

foreach (Circuit.Analysis.Parameter P in analysis.Parameters)
foreach (Circuit.Analysis.Parameter P in circuitSimulation.Analysis.Parameters)
{
namedArguments[P.Expression] = P.Value;

Circuit.Symbol S = P.Of.Tag as Circuit.Symbol;
if (S == null)
continue;
Expand Down Expand Up @@ -138,15 +130,15 @@ public LiveSimulation(Schematic Simulate, Audio.Device Device, Audio.Channel[] I

potControl.AddHandler(Binding.SourceUpdatedEvent, new RoutedEventHandler((o, args) =>
{
lock (namedArguments) namedArguments[P.Expression] = P.Value;
circuitSimulation.SetParameter(P.Expression, pot.PotValue);
}));

potControl.MouseEnter += (o, e) => potControl.Opacity = 0.95;
potControl.MouseLeave += (o, e) => potControl.Opacity = 0.4;
}

// Create the input and output controls.
IEnumerable<Circuit.Component> components = circuit.Components;
IEnumerable<Circuit.Component> components = circuitSimulation.Circuit.Components;

// Create audio input channels.
for (int i = 0; i < Inputs.Length; ++i)
Expand Down Expand Up @@ -187,7 +179,8 @@ public LiveSimulation(Schematic Simulate, Audio.Device Device, Audio.Channel[] I
foreach (var j in components.OfType<IButtonControl>().Where(x => x != b && x.Group == b.Group))
j.Click();
}
UpdateSimulation();

UpdateSimulation();
};

button.MouseEnter += (o, e) => button.Opacity = 0.95;
Expand Down Expand Up @@ -293,48 +286,24 @@ public LiveSimulation(Schematic Simulate, Audio.Device Device, Audio.Channel[] I
}
}

private Simulation MakeSimulation(TransientSolution solution)
private void UpdateSimulation()
{
return new Simulation(solution)
{
Log = Log,
Input = inputs.Keys.ToArray(),
Output = probes.Select(i => i.V).Concat(OutputChannels.Select(i => i.Signal)).ToArray(),
Arguments = namedArguments.Select(i => i.Key).ToArray(),
Oversample = Oversample,
Iterations = Iterations,
};
circuitSimulation.UpdateSimulation(inputs.Keys.ToArray(), probes.Select(i => i.V).Concat(OutputChannels.Select(i => i.Signal)).ToArray());
}

private void RebuildSolution()
{
lock (sync)
ProgressDialog.RunAsync(this, "Building circuit solution...", () =>
{
simulation = null;
ProgressDialog.RunAsync(this, "Building circuit solution...", () =>
try
{
try
{
ComputerAlgebra.Expression h = (ComputerAlgebra.Expression)1 / (stream.SampleRate * Oversample);
TransientSolution solution = Circuit.TransientSolution.Solve(circuit.Analyze(), h, Log);
simulation = MakeSimulation(solution);
}
catch (Exception Ex)
{
Log.WriteException(Ex);
}
});
}
}

private void UpdateSimulation()
{
ComputerAlgebra.Expression h = (ComputerAlgebra.Expression)1 / (stream.SampleRate * Oversample);
TransientSolution s = Circuit.TransientSolution.Solve(circuit.Analyze(), h, (ILog)Log);
lock (sync)
{
simulation = MakeSimulation(s);
}
UpdateSimulation();
}
catch (Exception Ex)
{
Log.WriteException(Ex);
}
});
}

private void ProcessSamples(int Count, Audio.SampleBuffer[] In, Audio.SampleBuffer[] Out, double Rate)
Expand All @@ -351,14 +320,11 @@ private void ProcessSamples(int Count, Audio.SampleBuffer[] In, Audio.SampleBuff
}

// Run the simulation.
lock (sync)
{
if (simulation != null)
RunSimulation(Count, In, Out, Rate);
else
foreach (Audio.SampleBuffer i in Out)
i.Clear();
}
if (circuitSimulation.HaveSimulation)
RunSimulation(Count, In, Out, Rate);
else
foreach (Audio.SampleBuffer i in Out)
i.Clear();

// Apply output gain.
for (int i = 0; i < Out.Length; ++i)
Expand All @@ -375,26 +341,17 @@ private void ProcessSamples(int Count, Audio.SampleBuffer[] In, Audio.SampleBuff
// These lists only ever grow, but they should never contain more than 10s of items.
readonly List<double[]> inputBuffers = new List<double[]>();
readonly List<double[]> outputBuffers = new List<double[]>();
readonly List<double> arguments = new List<double>();
private void RunSimulation(int Count, Audio.SampleBuffer[] In, Audio.SampleBuffer[] Out, double Rate)
{
try
{
// If the sample rate changed, we need to kill the simulation and let the foreground rebuild it.
if (Rate != (double)simulation.SampleRate)
{
simulation = null;
Dispatcher.InvokeAsync(() => RebuildSolution());
return;
}

inputBuffers.Clear();
foreach (Channel i in inputs.Values)
{
if (i is InputChannel input)
inputBuffers.Add(In[input.Index].Samples);
else if (i is SignalChannel channel)
inputBuffers.Add(channel.Buffer(Count, simulation.Time, simulation.TimeStep));
inputBuffers.Add(channel.Buffer(Count, circuitSimulation.Simulation.Time, circuitSimulation.Simulation.TimeStep));
}

outputBuffers.Clear();
Expand All @@ -403,12 +360,8 @@ private void RunSimulation(int Count, Audio.SampleBuffer[] In, Audio.SampleBuffe
for (int i = 0; i < Out.Length; ++i)
outputBuffers.Add(Out[i].Samples);

arguments.Clear();
foreach (double i in namedArguments.Select(i => i.Value))
arguments.Add(i);

// Process the samples!
simulation.Run(Count, inputBuffers, outputBuffers, arguments);
circuitSimulation.RunSimulation(Count, inputBuffers, outputBuffers);

// Show the samples on the oscilloscope.
long clock = Scope.Signals.Clock;
Expand All @@ -419,7 +372,6 @@ private void RunSimulation(int Count, Audio.SampleBuffer[] In, Audio.SampleBuffe
{
// If the simulation diverged more than one second ago, reset it and hope it doesn't happen again.
Log.WriteLine(MessageType.Error, "Error: " + Ex.Message);
simulation = null;
if ((double)Ex.At > Rate)
Dispatcher.InvokeAsync(() => RebuildSolution());
foreach (Audio.SampleBuffer i in Out)
Expand All @@ -429,7 +381,6 @@ private void RunSimulation(int Count, Audio.SampleBuffer[] In, Audio.SampleBuffe
{
// If there was a more serious error, kill the simulation so the user can fix it.
Log.WriteException(Ex);
simulation = null;
foreach (Audio.SampleBuffer i in Out)
i.Clear();
}
Expand All @@ -447,12 +398,9 @@ private void OnElementAdded(object sender, ElementEventArgs e)
};
Scope.Signals.Add(probe.Signal);
Scope.SelectedSignal = probe.Signal;
lock (sync)
{
probes.Add(probe);
if (simulation != null)
simulation.Output = probes.Select(i => i.V).Concat(OutputChannels.Select(i => i.Signal)).ToArray();
}
probes.Add(probe);
if (circuitSimulation.HaveSimulation)
UpdateSimulation();
}
}

Expand All @@ -462,12 +410,9 @@ private void OnElementRemoved(object sender, ElementEventArgs e)
{
Probe probe = (Probe)((Symbol)e.Element).Component;
Scope.Signals.Remove(probe.Signal);
lock (sync)
{
probes.Remove(probe);
if (simulation != null)
simulation.Output = probes.Select(i => i.V).Concat(OutputChannels.Select(i => i.Signal)).ToArray();
}
probes.Remove(probe);
if (circuitSimulation.HaveSimulation)
UpdateSimulation();
}
}

Expand Down
Loading
Loading