Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Event Models for GMX v2 (next iteration) #7314

Conversation

AIDataMaster
Copy link
Contributor

@AIDataMaster AIDataMaster commented Dec 12, 2024

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

This PR introduces new dbt models for the GMX project, covering both the Arbitrum and Avalanche blockchains. These models process and analyze event data to enable comprehensive insights into various activities on the platform.

Added Event Names:

  • GLVDepositCancelled
  • GLVDepositCreated
  • GLVDepositExecuted
  • GLVShiftCancelled
  • GLVShiftCreated
  • GLVShiftExecuted
  • GLVWithdrawalCancelled
  • GLVWithdrawalCreated
  • GLVWithdrawalExecuted
  • ShiftCreated
  • ShiftExecuted
  • WithdrawalCancelled
  • WithdrawalCreated
  • WithdrawalExecuted
  • GLVMarketsData
  • DepositCancelled
  • DepositCreated
  • DepositExecuted
  • GLVCreated
  • ClaimableFundingAmountPerSizeUpdated
  • FundingFeeAmountPerSizeUpdated

quick links for more information:

@AIDataMaster AIDataMaster marked this pull request as draft December 12, 2024 15:45
@jeff-dude jeff-dude added WIP work in progress dbt: daily covers the Daily dbt subproject labels Dec 12, 2024
@jeff-dude
Copy link
Member

marking as WIP, feel free to tag @Hosuke when you want final review 🙏

@AIDataMaster AIDataMaster marked this pull request as ready for review December 17, 2024 09:20
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Dec 17, 2024
@AIDataMaster
Copy link
Contributor Author

Hi @Hosuke. The PR is ready for the review :) 😎😋

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add uniqueness tests in the model schema.

@jeff-dude jeff-dude added WIP work in progress in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Dec 17, 2024
@AIDataMaster
Copy link
Contributor Author

@Hosuke I have made all changes. Could you please review the PR again?

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building time looks good.
Thank you @AIDataMaster

@Hosuke Hosuke added ready-for-merging and removed WIP work in progress in review Assignee is currently reviewing the PR labels Dec 19, 2024
@0xRobin 0xRobin merged commit dd8fbf7 into duneanalytics:main Dec 20, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: daily covers the Daily dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants