OTSea DEX on Base #7509
Merged
OTSea DEX on Base #7509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
github-actions
bot
added
ready-for-review
Hosuke
requested changes
Jan 21, 2025
There was a problem hiding this comment.
We can recover this file in this PR.
There was a problem hiding this comment.
Do you want me to revert to the state before this file was changed and start from there, or proceed with the current changes in this PR?
| @@ -1042,6 +1042,23 @@ models: | |||
| - check_dex_base_trades_seed: | |||
| seed_file: ref('akronswap_base_base_trades_seed') | |||
|
|
|||
| - name: otsea_base_base_trades | |||
There was a problem hiding this comment.
Please remember to add otsea_base_base_trades into dex_base_base_trades.
jeff-dude
added
WIP
Hosuke
approved these changes
Jan 22, 2025
| materialized = 'incremental', | ||
| file_format = 'delta', | ||
| incremental_strategy = 'merge', | ||
| unique_key = ['block_date', 'blockchain', 'project', 'version', 'tx_hash', 'evt_index'] |
There was a problem hiding this comment.
We need to make sure the unique_key match the key in the uniqueness test:
Suggested change
| unique_key = ['block_date', 'blockchain', 'project', 'version', 'tx_hash', 'evt_index'] | |
| unique_key = ['tx_hash', 'evt_index'] |
Hosuke
added
ready-for-merging
and removed
WIP
|
Please run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: