improvement for balancer erc4626 tokens #7595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
This was referenced Jan 30, 2025
github-actions
bot
added
ready-for-review
Hosuke
approved these changes
Feb 1, 2025
Hosuke
added
ready-for-merging
and removed
ready-for-review
jeff-dude
approved these changes
Feb 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
This PR helps account for right price of ERC4626 tokens, given that some have different decimals from their underlying tokens, which was impacting the correct ratio between deposits and shares.
It also manually tracks csUSDL to USDL instead of wUSDL, given that wUSDL isn't tracked on coinpaprika
quick links for more information: