const where it makes sense

duzda · Feb 9, 2023 · 901046a · 901046a
1 parent ed05bd8
commit 901046a
Show file tree

Hide file tree

Showing 36 changed files with 67 additions and 67 deletions.
diff --git a/include/cache/covers/cover.hpp b/include/cache/covers/cover.hpp
@@ -17,6 +17,6 @@ class Cache::Covers::Cover {
      * 
      * @return Pointer to the cover art.
      */
-    virtual Glib::RefPtr<Gdk::Pixbuf> getIcon(std::filesystem::path path, uint size) = 0;
+    virtual Glib::RefPtr<Gdk::Pixbuf> getIcon(const std::filesystem::path& path, uint size) = 0;
 private:
 };
diff --git a/include/cache/covers/implementation/coverfirst.hpp b/include/cache/covers/implementation/coverfirst.hpp
@@ -11,7 +11,7 @@ class Cache::Covers::CoverFirst : public Cache::Covers::Cover {
     CoverFirst();
     ~CoverFirst();
 
-    Glib::RefPtr<Gdk::Pixbuf> getIcon(std::filesystem::path path, uint size);
+    Glib::RefPtr<Gdk::Pixbuf> getIcon(const std::filesystem::path& path, uint size);
 private:
-    bool isNotChild(std::filesystem::path parent, std::filesystem::path child);
+    bool isNotChild(const std::filesystem::path& parent, const std::filesystem::path& child) const;
 };
diff --git a/include/cache/covers/implementation/metadatafirst.hpp b/include/cache/covers/implementation/metadatafirst.hpp
@@ -11,8 +11,8 @@ class Cache::Covers::MetadataFirst : public Cache::Covers::Cover {
     MetadataFirst();
     ~MetadataFirst();
 
-    Glib::RefPtr<Gdk::Pixbuf> getIcon(std::filesystem::path path, uint size);
+    Glib::RefPtr<Gdk::Pixbuf> getIcon(const std::filesystem::path& path, uint size);
 private:
-    bool isNotChild(std::filesystem::path parent, std::filesystem::path child);
-    Glib::RefPtr<Gdk::Pixbuf> hasChildrenIcon(std::filesystem::path cachePath, std::filesystem::path path, uint size);
+    bool isNotChild(const std::filesystem::path& parent, const std::filesystem::path& child) const;
+    Glib::RefPtr<Gdk::Pixbuf> hasChildrenIcon(const std::filesystem::path& cachePath, const std::filesystem::path& path, uint size);
 };
diff --git a/include/cache/covers/implementation/metadataonly.hpp b/include/cache/covers/implementation/metadataonly.hpp
@@ -11,8 +11,8 @@ class Cache::Covers::MetadataOnly : public Cache::Covers::Cover {
     MetadataOnly();
     ~MetadataOnly();
 
-    Glib::RefPtr<Gdk::Pixbuf> getIcon(std::filesystem::path path, uint size);
+    Glib::RefPtr<Gdk::Pixbuf> getIcon(const std::filesystem::path& path, uint size);
 private:
-    bool isNotChild(std::filesystem::path parent, std::filesystem::path child);
-    Glib::RefPtr<Gdk::Pixbuf> hasChildrenIcon(std::filesystem::path cachePath, std::filesystem::path path, uint size);
+    bool isNotChild(const std::filesystem::path& parent, const std::filesystem::path& child) const;
+    Glib::RefPtr<Gdk::Pixbuf> hasChildrenIcon(const std::filesystem::path& cachePath, const std::filesystem::path& path, uint size);
 };
diff --git a/include/cache/covers/utils.hpp b/include/cache/covers/utils.hpp
@@ -18,7 +18,7 @@ class Cache::Covers::Utils {
      * 
      * @return Path to the cache file
      */
-    static std::filesystem::path createCachePath(std::filesystem::path path, uint size);
+    static std::filesystem::path createCachePath(const std::filesystem::path& path, uint size);
 private:
     Utils();
     ~Utils();

diff --git a/include/cache/treemodel/serializer.hpp b/include/cache/treemodel/serializer.hpp
@@ -17,7 +17,7 @@ class Cache::TreeModel::Serializer {
      * 
      * @return True if tree should be recovered
     */
-    static bool shouldRecover(std::filesystem::path path);
+    static bool shouldRecover(const std::filesystem::path& path);
 
     static void clearModel();
 private:

diff --git a/include/filebrowser.hpp b/include/filebrowser.hpp
@@ -15,7 +15,7 @@ class Filebrowser {
      * 
      * @return Vector of directory entries for path
      */
-    static std::vector<std::filesystem::directory_entry> getFileList(std::filesystem::path path, bool sort, bool showHiddenFiles);
+    static std::vector<std::filesystem::directory_entry> getFileList(const std::filesystem::path& path, bool sort, bool showHiddenFiles);
 
     /**
      * @param directory
@@ -24,7 +24,7 @@ class Filebrowser {
      * 
      * @return True if directory contains file, false otherwise.
      */
-    static bool hasFile(std::filesystem::path directory, std::vector<std::string> acceptedFiles, std::string* outputFile);
+    static bool hasFile(const std::filesystem::path& directory, std::vector<std::string> acceptedFiles, std::string* outputFile);
 private:
     Filebrowser();
     virtual ~Filebrowser();

diff --git a/include/gui/addressbox.hpp b/include/gui/addressbox.hpp
@@ -16,7 +16,7 @@ class GUI::Addressbox : public Gtk::HBox
 
     void initialize(GUI::DispatcherBridge* bridge, GUI::FBTreeView* view, FBTreeFilter* filter, FBTreeModel* model);
     void setAddress(std::string addres);
-    std::string getAddress();
+    std::string getAddress() const;
 
     /**
      * Changes progress of the action of Addressbox.

diff --git a/include/gui/dispatcherbridge.hpp b/include/gui/dispatcherbridge.hpp
@@ -14,7 +14,7 @@ class GUI::DispatcherBridge {
 
     void initialize(Addressbox* addressbox, Searchbar* searchbar, FBTreeView* view, FBTreeModel* model);
 
-    bool inProgress();
+    bool inProgress() const;
 
     void onStart();
 

diff --git a/include/gui/fbtreemodel.hpp b/include/gui/fbtreemodel.hpp
@@ -30,14 +30,14 @@ class GUI::FBTreeModel : public Gtk::TreeStore {
      * 
      * @return Double between 0 and 1, 1 when finished
      */
-    double getProgress();
+    double getProgress() const;
 
     /**
      * Sets new root directory, refreshTree should probably be called immediately after.
      * 
      * @param newDirectory New root directory
      */
-    void setTreeRoot(std::filesystem::path newDirectory);
+    void setTreeRoot(const std::filesystem::path& newDirectory);
 
     /**
      * Creates new thread that refreshes tree, removes all entries, and fills them again. 
@@ -85,15 +85,15 @@ class GUI::FBTreeModel : public Gtk::TreeStore {
      * @param entry Path to the new child.
      * @param child Parent to of the current entry, can be null.
      */
-    void fillRow(std::filesystem::directory_entry entry, const Gtk::TreeNodeChildren* parent = nullptr);
+    void fillRow(const std::filesystem::directory_entry& entry, const Gtk::TreeNodeChildren* parent = nullptr);
 
     /**
      * Fills row of treeview, but is allowed to be exited prematurely. (This should be used when adding children of a node)
      * 
      * @param entry Path to the new child.
      * @param child Parent to the current entry.
      */
-    void fillChildrenRow(std::filesystem::directory_entry entry, const Gtk::TreeNodeChildren* parent);
+    void fillChildrenRow(const std::filesystem::directory_entry& entry, const Gtk::TreeNodeChildren* parent);
 
     /**
      * Fills information row to treeview.

diff --git a/include/gui/views/fbtreeview.hpp b/include/gui/views/fbtreeview.hpp
@@ -24,21 +24,21 @@ class GUI::FBTreeView : public Gtk::TreeView {
      * 
      * @return URI of selected row
      */
-    std::string getSelectedURI();
+    std::string getSelectedURI() const;
 
     /**
      * Returns all selected URIs from mTreeView.
      * 
      * @return Vector of selected rows
      */
-    std::vector<std::string> getSelectedURIs();
+    std::vector<std::string> getSelectedURIs() const;
 
     /**
      * Returns true if any row in mTreeView is selected.
      * 
      * @return True if any row is selected, false otherwise.
      */
-    bool hasSelected();
+    bool hasSelected() const;
 private:
     using Gtk::TreeView::set_model;
 

diff --git a/include/iconutils.hpp b/include/iconutils.hpp
@@ -32,7 +32,7 @@ class IconUtils {
      * 
      * @return Pointer to the icon.
      */
-    static Glib::RefPtr<Gdk::Pixbuf> getIcon(std::filesystem::path path, uint size);
+    static Glib::RefPtr<Gdk::Pixbuf> getIcon(const std::filesystem::path& path, uint size);
 private:
     IconUtils();
     ~IconUtils();

diff --git a/include/metadata/implementation/flacreader.hpp b/include/metadata/implementation/flacreader.hpp
@@ -7,6 +7,6 @@ class FlacReader : public ID3v2Reader {
     FlacReader();
     ~FlacReader();
 
-    Glib::RefPtr<Gdk::Pixbuf> getImage(std::filesystem::path path, int size) override;
+    Glib::RefPtr<Gdk::Pixbuf> getImage(const std::filesystem::path& path, int size) override;
 private:
 };
diff --git a/include/metadata/implementation/mp3reader.hpp b/include/metadata/implementation/mp3reader.hpp
@@ -7,6 +7,6 @@ class MP3Reader : public ID3v2Reader {
     MP3Reader();
     ~MP3Reader();
 
-    Glib::RefPtr<Gdk::Pixbuf> getImage(std::filesystem::path path, int size);
+    Glib::RefPtr<Gdk::Pixbuf> getImage(const std::filesystem::path& path, int size);
 private:
 };
diff --git a/include/metadata/implementation/oggreader.hpp b/include/metadata/implementation/oggreader.hpp
@@ -7,6 +7,6 @@ class OggReader : public Reader {
     OggReader();
     ~OggReader();
 
-    Glib::RefPtr<Gdk::Pixbuf> getImage(std::filesystem::path path, int size);
+    Glib::RefPtr<Gdk::Pixbuf> getImage(const std::filesystem::path& path, int size);
 private:
 };
diff --git a/include/metadata/implementation/wavreader.hpp b/include/metadata/implementation/wavreader.hpp
@@ -7,6 +7,6 @@ class WavReader : public ID3v2Reader {
     WavReader();
     ~WavReader();
 
-    Glib::RefPtr<Gdk::Pixbuf> getImage(std::filesystem::path path, int size);
+    Glib::RefPtr<Gdk::Pixbuf> getImage(const std::filesystem::path& path, int size);
 private:
 };
diff --git a/include/metadata/reader.hpp b/include/metadata/reader.hpp
@@ -9,7 +9,7 @@ class Reader {
 public:
     virtual ~Reader();
 
-    virtual Glib::RefPtr<Gdk::Pixbuf> getImage(std::filesystem::path path, int size) = 0;
+    virtual Glib::RefPtr<Gdk::Pixbuf> getImage(const std::filesystem::path& path, int size) = 0;
 protected:
     Glib::RefPtr<Gdk::Pixbuf> getImageFromData(TagLib::ByteVector bytes, int size);
 };
diff --git a/include/metadata/readerfactory.hpp b/include/metadata/readerfactory.hpp
@@ -19,7 +19,7 @@ class ReaderFactory {
      * 
      * @return Pointer to the image.
      */
-    static Glib::RefPtr<Gdk::Pixbuf> getImage(std::filesystem::path path, int size, bool* shouldCache);
+    static Glib::RefPtr<Gdk::Pixbuf> getImage(const std::filesystem::path& path, int size, bool* shouldCache);
 private:
     ReaderFactory();
     ~ReaderFactory();

diff --git a/include/plugin/settings.hpp b/include/plugin/settings.hpp
@@ -20,12 +20,12 @@ class Settings {
      */
     void onUpdate();
 
-    std::string getDefaultPath();
-    int getIconSize();
-    int getDoubleclickReplace();
-    int getAlbumAlgorithm();
+    std::string getDefaultPath() const;
+    int getIconSize() const;
+    int getDoubleclickReplace() const;
+    int getAlbumAlgorithm() const;
 
-    std::vector<std::string> getValidExtensions();
+    std::vector<std::string> getValidExtensions() const;
 private:
     Settings();
 

diff --git a/src/cache/covers/implementation/coverfirst.cpp b/src/cache/covers/implementation/coverfirst.cpp
@@ -10,7 +10,7 @@ using namespace Cache::Covers;
 CoverFirst::CoverFirst() {
 }
 
-Glib::RefPtr<Gdk::Pixbuf> CoverFirst::getIcon(std::filesystem::path path, uint size) {
+Glib::RefPtr<Gdk::Pixbuf> CoverFirst::getIcon(const std::filesystem::path& path, uint size) {
     Glib::RefPtr<Gdk::Pixbuf> icon;
     static Glib::RefPtr<Gdk::Pixbuf> lastIcon;
     static std::string lastDirectory;
@@ -48,7 +48,7 @@ Glib::RefPtr<Gdk::Pixbuf> CoverFirst::getIcon(std::filesystem::path path, uint s
     return icon;
 }
 
-bool CoverFirst::isNotChild(std::filesystem::path parent, std::filesystem::path child) {
+bool CoverFirst::isNotChild(const std::filesystem::path& parent, const std::filesystem::path& child) const {
     return parent == "" || child.string().find(parent) == std::string::npos || 
         child.string().size() <= parent.string().size() || child.string()[parent.string().size()] != '/';
 }

diff --git a/src/cache/covers/implementation/metadatafirst.cpp b/src/cache/covers/implementation/metadatafirst.cpp
@@ -10,7 +10,7 @@ using namespace Cache::Covers;
 MetadataFirst::MetadataFirst() {   
 }
 
-Glib::RefPtr<Gdk::Pixbuf> MetadataFirst::getIcon(std::filesystem::path path, uint size) {
+Glib::RefPtr<Gdk::Pixbuf> MetadataFirst::getIcon(const std::filesystem::path& path, uint size) {
     Glib::RefPtr<Gdk::Pixbuf> icon;
     static std::string lastDirectory;
 
@@ -57,12 +57,12 @@ Glib::RefPtr<Gdk::Pixbuf> MetadataFirst::getIcon(std::filesystem::path path, uin
     return icon;
 }
 
-bool MetadataFirst::isNotChild(std::filesystem::path parent, std::filesystem::path child) {
+bool MetadataFirst::isNotChild(const std::filesystem::path& parent, const std::filesystem::path& child) const {
     return parent == "" || child.string().find(parent) == std::string::npos || 
         child.string().size() <= parent.string().size() || child.string()[parent.string().size()] != '/';
 }
 
-Glib::RefPtr<Gdk::Pixbuf> MetadataFirst::hasChildrenIcon(std::filesystem::path cachePath, std::filesystem::path path, uint size) {
+Glib::RefPtr<Gdk::Pixbuf> MetadataFirst::hasChildrenIcon(const std::filesystem::path& cachePath, const std::filesystem::path& path, uint size) {
     for (const auto &entry : std::filesystem::recursive_directory_iterator(path)) {
         if (entry.is_directory()) {
             std::string outputName;

diff --git a/src/cache/covers/implementation/metadataonly.cpp b/src/cache/covers/implementation/metadataonly.cpp
@@ -10,7 +10,7 @@ using namespace Cache::Covers;
 MetadataOnly::MetadataOnly() {   
 }
 
-Glib::RefPtr<Gdk::Pixbuf> MetadataOnly::getIcon(std::filesystem::path path, uint size) {
+Glib::RefPtr<Gdk::Pixbuf> MetadataOnly::getIcon(const std::filesystem::path& path, uint size) {
     Glib::RefPtr<Gdk::Pixbuf> icon;
     static std::string lastDirectory;
 
@@ -45,12 +45,12 @@ Glib::RefPtr<Gdk::Pixbuf> MetadataOnly::getIcon(std::filesystem::path path, uint
     return icon;
 }
 
-bool MetadataOnly::isNotChild(std::filesystem::path parent, std::filesystem::path child) {
+bool MetadataOnly::isNotChild(const std::filesystem::path& parent, const std::filesystem::path& child) const {
     return parent == "" || child.string().find(parent) == std::string::npos || 
         child.string().size() <= parent.string().size() || child.string()[parent.string().size()] != '/';
 }
 
-Glib::RefPtr<Gdk::Pixbuf> MetadataOnly::hasChildrenIcon(std::filesystem::path cachePath, std::filesystem::path path, uint size) {
+Glib::RefPtr<Gdk::Pixbuf> MetadataOnly::hasChildrenIcon(const std::filesystem::path& cachePath, const std::filesystem::path& path, uint size) {
     for (const auto &entry : std::filesystem::recursive_directory_iterator(path)) {
         if (!entry.is_directory()) {
             bool useCache = false;

diff --git a/src/cache/covers/utils.cpp b/src/cache/covers/utils.cpp
@@ -4,7 +4,7 @@
 
 using namespace Cache::Covers;
 
-std::filesystem::path Utils::createCachePath(std::filesystem::path path, uint size) {
+std::filesystem::path Utils::createCachePath(const std::filesystem::path& path, uint size) {
     std::string cache = Cache::Utils::createCacheBasePath().string() + "/icons/" + std::to_string(size) + "/";
 
     if (!std::filesystem::exists(cache)) {

diff --git a/src/cache/treemodel/serializer.cpp b/src/cache/treemodel/serializer.cpp
@@ -41,7 +41,7 @@ void Serializer::load(GUI::FBTreeModel* model) {
     }
 }
 
-bool Serializer::shouldRecover(std::filesystem::path path) {
+bool Serializer::shouldRecover(const std::filesystem::path& path) {
     if (!Serializer::exists()) {
         return false;
     }

diff --git a/src/filebrowser.cpp b/src/filebrowser.cpp
@@ -18,7 +18,7 @@
 
 #include "settings.hpp"
 
-std::vector<std::filesystem::directory_entry> Filebrowser::getFileList(std::filesystem::path path, bool sort, bool showHiddenFiles) {
+std::vector<std::filesystem::directory_entry> Filebrowser::getFileList(const std::filesystem::path& path, bool sort, bool showHiddenFiles) {
     std::vector<std::filesystem::directory_entry> files = {};
 
     for(const auto &entry : std::filesystem::directory_iterator(path)) {
@@ -54,15 +54,15 @@ std::vector<std::filesystem::directory_entry> Filebrowser::getFileList(std::file
 
     if (sort) {
         std::sort(files.begin(), files.end(), 
-            [](const std::filesystem::directory_entry &s1, const std::filesystem::directory_entry &s2) -> bool {
+            [](const std::filesystem::directory_entry& s1, const std::filesystem::directory_entry& s2) -> bool {
                 return strcasecmp(s1.path().c_str(), s2.path().c_str()) < 0 ? true : false;
             });
     }
 
     return files;
 }
 
-bool Filebrowser::hasFile(std::filesystem::path directory, std::vector<std::string> acceptedFiles, std::string* outputFile) {
+bool Filebrowser::hasFile(const std::filesystem::path& directory, std::vector<std::string> acceptedFiles, std::string* outputFile) {
     auto path = directory.string();
     for (auto &file : acceptedFiles) {
         if (std::filesystem::exists(path + '/' + file)) {

diff --git a/src/gui/addressbox.cpp b/src/gui/addressbox.cpp
@@ -39,7 +39,7 @@ void Addressbox::setAddress(std::string address) {
     this->on_go_button_click();
 }
 
-std::string Addressbox::getAddress() {
+std::string Addressbox::getAddress() const {
     return this->mAddressBar.get_text();
 }
 

diff --git a/src/gui/dispatcherbridge.cpp b/src/gui/dispatcherbridge.cpp
@@ -19,7 +19,7 @@ void DispatcherBridge::initialize(Addressbox* addressbox, Searchbar* searchbar,
     this->mModel = model;
 }
 
-bool DispatcherBridge::inProgress() {
+bool DispatcherBridge::inProgress() const {
     return this->mInProgress;
 }