Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamodb : implicit Map[String, T] #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

etaty
Copy link
Contributor

@etaty etaty commented Dec 9, 2015

If you know how to remove the implicitly[] ?

@etaty
Copy link
Contributor Author

etaty commented Dec 11, 2015

should be ok for review/merge

@etaty
Copy link
Contributor Author

etaty commented Dec 11, 2015

Hum there is a big problem
http://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DataModel.html

DynamoDB also supports types that represent number sets, string sets and binary sets. Attributes such as an Authors attribute in a book item and a Color attribute of a product item are examples of String Set type attributes. Because each of these types is a set, the values in each must be unique. Attribute sets are not ordered; the order of the values returned in a set is not preserved. DynamoDB does not support empty sets.

But the current encoder convert a scala Iterable to a dynamoDB Set, but it is wrong.
For me we should not even support dynamoDB Set because they can't be empty. But all scala collection can be empty

@mingchuno
Copy link

@etaty
I have forked this repo and publish it under version 0.9.0
https://github.com/mingchuno/aws-wrap

Can you submit a new PR if you still need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants