Avoid log warnings when image licence is not set #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Note use of en_GB "licence" except in rel which uses en_US "license") * set the "other" licence if not specified * change the program flow to have one return point * use 'rel="license"' * separate the licence and attribution with a comma ``` PHP Warning: Undefined array key "" in /var/www/html/wp-content/themes/gds-blogs/lib/image-licensing.php on line 52; PHP Warning: Trying to access array offset on null in /var/www/html/wp-content/themes/gds-blogs/lib/image-licensing.php on line 57 ``` * https://html.spec.whatwg.org/multipage/links.html#link-type-license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue can only be reproduced when adding images without specified licenses via the admin interface.