Contain all visible content in landmark regions #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richpjames
approved these changes
May 22, 2024
Yup. With it being a reactive app, it might be hard to define points at which automatic checks need to refire, but one to think about |
We had some WCAG violations about content not being contained by landmark regions. This adds all visible content into `header` or `main`. We can add a `footer` or other regions later if/when useful https://dequeuniversity.com/rules/axe/4.9/landmark-one-main?application=AxeChrome
yndajas
force-pushed
the
add-landmark-regions
branch
from
7912f00 to
3c24261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some WCAG violations about content not being contained by landmark regions. This adds all visible content into
headerormain. We can add afooteror other regions later if/when usefulhttps://dequeuniversity.com/rules/axe/4.9/landmark-one-main?application=AxeChrome