WIP Architecture #60
Closed
WIP Architecture #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richpjames
reviewed
Feb 20, 2024
doc/architecture-crc.md
Outdated
| | - receives responses to the question | | | ||
| | - determines correctness of responses | | | ||
| | - determines when to end the round | | | ||
| | - determines points players win or loose | | |
There was a problem hiding this comment.
there are quite a lot of responsibilities here but they're all closely related so I feel ok about it.
richpjames
reviewed
Feb 20, 2024
doc/architecture-crc.md
Outdated
|
|
||
|
|
||
| | Responsibilities | Collaborators | | ||
| |-------------------------------|-----------------| |
There was a problem hiding this comment.
I struggled a bit with the responsibilities with this one. I'm a bit confused over it's purpose.
There was a problem hiding this comment.
+1. I wondered about moving it into the index, but then the index might be doing too much. Maybe the methods after onCreated should live in different places
richpjames
force-pushed
the
architecture
branch
from
022a392 to
ae4e96e
Compare
Merged
yndajas
force-pushed
the
architecture
branch
from
ae4e96e to
21b9431
Compare
yndajas
force-pushed
the
architecture
branch
2 times, most recently
from
8eb31a0 to
40a96ea
Compare
richpjames
force-pushed
the
architecture
branch
from
40a96ea to
07a8c3f
Compare
yndajas
force-pushed
the
architecture
branch
from
07a8c3f to
40a96ea
Compare
This caused some confusion about what the original non-destructured argument was so we've undone it for clarity Co-authored-by: Liz Daly <50752284+lookupdaily@users.noreply.github.com> Co-authored-by: Rich James <richpjames@users.noreply.github.com>
This is really a single event (note the union typing), despite being used as the value for an `events` key, so the type is updated here for accuracy
The `--watch` argument was in the wrong place in the `package.json` `start` script. This separates the script into a watch and non-watch version and fixes the watch version The watch version is then used in `script/server` so that we are watching for changes by default - useful for dev purposes Co-authored-by: Liz Daly <50752284+lookupdaily@users.noreply.github.com> Co-authored-by: Rich James <richpjames@users.noreply.github.com>
Co-authored-by: Liz Daly <50752284+lookupdaily@users.noreply.github.com> Co-authored-by: Rich James <richpjames@users.noreply.github.com>
I thought it might be useful to reason about the architecture using the [CRC card format](https://en.wikipedia.org/wiki/Class-responsibility-collaboration_card). These aren't all classes but they all have responsibilities and collaborators (consumers/dependencies). I've tried to describe things as they are rather than how they should be.
yndajas
force-pushed
the
architecture
branch
from
40a96ea to
d5b3bc3
Compare
yndajas
force-pushed
the
tidy-up
branch
5 times, most recently
from
944114e to
7e9b74d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.