Fix dependency parsing from Renovate dependency dashboard #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlivings-dxw
force-pushed
the
fix/renovate-dependency-dashboard-parsing
branch
from
e1a00ce to
6a3037b
Compare
richpjames
approved these changes
Sep 13, 2024
danlivings-dxw
force-pushed
the
fix/renovate-dependency-dashboard-parsing
branch
from
6a3037b to
ec39186
Compare
This changes the parsing to only process lines between the 'Detected dependencies' header and the next horizontal rule, which fixes an issue where dependency references in previous sections of the dashboard were being parsed incorrectly and sometimes causing weird results.
danlivings-dxw
force-pushed
the
fix/renovate-dependency-dashboard-parsing
branch
from
ec39186 to
f0156a1
Compare
danlivings-dxw
deleted the
fix/renovate-dependency-dashboard-parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the parsing to only process lines between the 'Detected dependencies' header and the next horizontal rule, which fixes an issue where dependency references in previous sections of the dashboard were being parsed incorrectly and sometimes causing weird results.
Example of incorrect parsing (from the nest-template repo's dashboard):
Example of fixed parsing (note that Node is listed in the dashboard with two different versions as
Dockerfileand.node-versiondisagree):