Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/psalm #228

Merged
merged 22 commits into from
Oct 5, 2023
Merged

Chore/psalm #228

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e9931b8
Install Psalm and add basic config
RobjS Oct 3, 2023
0a9cfd1
Remove unnecessary loop
RobjS Oct 3, 2023
eb91ffd
Ignore PossiblyUnusedMethod errors
RobjS Oct 3, 2023
4decd4f
Suppress UnusedClass for Whippet classes
RobjS Oct 3, 2023
2c95fc4
Suppress Inspection UnusedProperty errors
RobjS Oct 3, 2023
fa62c60
Make `clone_no_checkout` command call pass the right args
RobjS Oct 3, 2023
dc36ddf
Reference global exception class
RobjS Oct 3, 2023
c3bf6a1
Declare and set default value for `releases_manifest` property
RobjS Oct 3, 2023
8a185a5
Use array_keys to eliminate unused value variables
RobjS Oct 4, 2023
9091618
Declare `plugins_locked` property
RobjS Oct 4, 2023
be29dc6
Suppress WHIPPET_ROOT undefined Psalm error
RobjS Oct 4, 2023
05e3130
Cast array key as string before echoing
RobjS Oct 4, 2023
91b1d62
Suppress undefined property fetch issue
RobjS Oct 4, 2023
0bc7c65
Cast array key as string before concatenating string
RobjS Oct 4, 2023
ce45d57
Suppress Psalm unused class warning on Whippet
RobjS Oct 4, 2023
dcbedff
Remove unused params in constructors
RobjS Oct 4, 2023
baf650d
Use `E_USER_ERROR`, as `E_USER_FATAL` does not exist
RobjS Oct 4, 2023
c2e0d08
Add return type will change attribute to toString method
RobjS Oct 4, 2023
00555d7
Run Psalm as part of the test script
RobjS Oct 4, 2023
c1da9c2
Run Psalm in all supported PHP versions in CI
RobjS Oct 4, 2023
acf8e86
Allow for the fact $this->plugins_locked is an object
RobjS Oct 4, 2023
1dce714
Update CHANGELOG for Psalm usage
RobjS Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Git/Git.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function clone_no_checkout($repository)
return false;
}

$this->run_command("mv {$tmpdir}/.git {$this->repo_path}");
$this->run_command(['mv', $tmpdir . '/.git', $this->repo_path]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment: there's a typo in the commit message here s/no/not/g

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Fixed in a rebase I'll push post-approval.


return true;
}
Expand Down