Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whippet deps describe shows the most detailed semver version #234

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

snim2
Copy link
Contributor

@snim2 snim2 commented Jan 18, 2024

In our plugin repositories, we now tag commits with major version tags, e.g. 'v1' and more detailed tags, e.g. 'v1.2.3'.

When we run 'whippet deps describe' we always want the version number with the most fidelity.

Resolves: https://...

  • Includes tests (if new features are introduced)
  • Commit message includes link to the ticket/issue
  • Changelog updated
  • PR open against dxw's Homebrew Tap to point the Whippet formula to the new version number

Testing

In a project repo, run whippet deps update both on this branch and from main. You should see differences like this:

❯ whippet-test deps describe
{
    "plugins": {
        ...
        "advanced-custom-fields-pro": "v6",
    }
}%

vs

❯ whippet-test deps describe
{
    "plugins": {
        ...
        "advanced-custom-fields-pro": "v6.2.5",
    }
}%

In our plugin repositories, we now tag commits with major
version tags, e.g. 'v1' and more detailed tags, e.g. 'v1.2.3'.

When we run 'whippet deps describe' we always want the
version number with the most fidelity.
@snim2 snim2 merged commit 0a2417f into main Jan 19, 2024
5 checks passed
@snim2 snim2 deleted the chore/always-describe-most-detailed-semver-version branch January 19, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants