Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/deploy tests #48

Closed
wants to merge 71 commits into from
Closed

Feature/deploy tests #48

wants to merge 71 commits into from

Conversation

mallorydxw
Copy link
Contributor

In progress.

  • Test successful deployment
  • Test "release did not validate" path
  • Add code coverage to check how much of the class is tested
  • Write tests until Deployment is at 100%
    • I keep getting weird errors related to using the VFS, so I guess we'll skip this step
  • Move Module/Release as it's not a command
  • Test Module/Release
  • Stop using WhippetHelpers
  • PHP Warning: symlink(): No such file or directory in /workbench/src/github.com/dxw/whippet/src/Modules/Release.php on line 138

mallorydxw added 30 commits April 1, 2016 13:01
@mallorydxw
Add Modules/Helpers/FileLocator
08c8621
@mallorydxw
Look for plugins or whippet.json files
35944fa
@mallorydxw
Add Modules/Helpers/Dependencies
ca1a28a
@mallorydxw
Add Modules/Helpers/WhippetLock
80c7951
@mallorydxw
Add Modules/Dependencies
ea838e0
@mallorydxw
Pre-DRY tests
7a5dfd9
@mallorydxw
Handle already-cloned repos
a2b7821
@mallorydxw
Add fromString/fromFile static methods to WhippetLock
8a90ddc
@mallorydxw
Show useful output
1c0f953
@mallorydxw
s/Dependencies/DependenciesInstaller/
b6fa19c
@mallorydxw
Move new classes out of Modules\Helpers
7eac459
@mallorydxw
Check the hash before installing
236974f
@mallorydxw
Move some test helpers into a separate trait
43a5480
@mallorydxw
Output errors
21342cc
@mallorydxw
Add DependenciesUpdater
ebf905a
@mallorydxw
Add update command
ee0858f
@mallorydxw
Add paths to gitignore
0bfd536
@mallorydxw
Add plugins to DependenciesInstall
a2b9c7a
@mallorydxw
Add plugins to DependenciesUpdater
396eb7a
@mallorydxw
Add dependencies migrate command
0f6eb92
@mallorydxw
mv WhippetLock Files/WhippetLock
f144371
@mallorydxw
Move some functionality from DependenciesUpdate into WhippetLock
fd8838d
@mallorydxw
Rename dependencies, and update FileLocator usage
041474d 
- Rename Dependencies* classes
- Pass directory instead of FileLocator
@mallorydxw
Add isErr check to Migration
84d2a71
@mallorydxw
Update: test for failed git command
3cf365a
@mallorydxw
FileLocator: update message
7798ad7
@mallorydxw
s/FileLocator/DirectoryLocator/
a9c7cc4
@mallorydxw
DirectoryLocator: Prevent bug with plugins directory
1b0183d
@mallorydxw
migrate: Pretty-print whippet.json
4c5e840
@mallorydxw
Pretty-print whippet.lock
8979ecc
@mallorydxw mallorydxw self-assigned this Apr 7, 2016
@mallorydxw mallorydxw force-pushed the feature/deploy-tests branch from f974dff to 56fa217 Compare April 7, 2016 18:38
@mallorydxw mallorydxw force-pushed the feature/deploy-tests branch from 56fa217 to 3be3cc2 Compare April 8, 2016 13:20
@mallorydxw mallorydxw force-pushed the feature/deploy-tests branch from 3be3cc2 to 791f1b5 Compare April 8, 2016 13:30
@mallorydxw
Copy link
Contributor Author

Ugh. This is painful.

Edit: To elaborate, I spent forever trying to figure out why file_put_contents isn't working for the releases directory. Unsuccessfully. I then tried starting to write tests for Release and whippet_init() made that painful.

@mallorydxw
Copy link
Contributor Author

This needs a lot of work. I'll close for the moment.

@mallorydxw mallorydxw closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mallorydxw mallorydxw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mallorydxw