-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signals proxy #10
Signals proxy #10
Conversation
@aelbore this PR introduces signals-proxy store. It seems to be a bit less efficient than either just signals or proxy store in terms of performance (negligibly though). Also it adds some extra 2kb, since @preact/signals-core is included. But it is more resilient and supports signals as values.
|
Hey thanks for this, but actually I just want to reuse my signal store so that I don't want to rewrite it again, logics in the it a bit a lot so no time to rewrite it if this compromise your library and no performance benefits, I can just Create small adapter or utility to bridge my existing store to state of sprae. I understand correctly |
This changes store to comprise signals, rather than own pubsub.
Also streamlines / cleans code & fixes some non-obvious bugs.
Fixes #9 and addresses #8.