Ignore...test #36
Closed
Ignore...test #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment implied it was used by lsp-dylan but it isn't, at least not any more.
* Improve warnings for find-active-packages * Add current-dylan-package instead of storing the release in the workspace. This is only needed by the publish command and should find the dylan-package.json file nearest the working directory.
The main point was to make the code easier to follow. Initial implementation I was feeling my way in the dark, this time a few things were clarified. I see the light!... * Some commands (help, list, etc.) don't need a full scan of the workspace, so I made all the `lids-by-*` slots be lazily computed. * Scanning the workspace is more clearly separated into first scanning the active packages and then, if necessary, finding and installing dependencies before scanning them for libraries. * Move LID file code to its own file, lid.dylan.
It was a bit arbitrary to put some of the simple commands into simple-commands.dylan. Better to be consistent.
What was I thinking?
...by using deft-shared to re-export everything in a way that can be used by the workspaces and pacman modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.