Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple targets at the end of the galvanize call are passed in reverse order #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MarcelloDiSimone
Copy link

The last changes that added chained target support, append the targets in reverse order to the galvanized grunt task. For example calling:

grunt.task.run(['galvanize:express:default:stop']);

calls the express task in this order:

express:stop:default

not as I would expect:

express:default:stop

I changed the handling of passed targets to keep the predefined order. I also rewrote the code to ES6 syntax and fixed the included mocha test, which didn't run the expectations but where still passing.

If for some reason the reverse handling of targets were intended, for some reason I don't know, please ignore the PR..

Cheers

@MarcelloDiSimone
Copy link
Author

Are there any news about this change request or is the project dead?

@dylancwood
Copy link
Owner

dylancwood commented Jun 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants