Allocate enough memory when deserializing types [20095] #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tempate <danieldiaz@eprosima.com>
Tempate
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 20.36% 20.19% -0.18%
==========================================
Files 29 29
Lines 2715 2714 -1
Branches 1423 1423
==========================================
- Hits 553 548 -5
- Misses 1694 1704 +10
+ Partials 468 462 -6 ☔ View full report in Codecov by Sentry. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, the DDS Replayer was creating a buffer with a uint16_t size to deserialize data in, and, sometimes, it was bumping into NotEnoughMemoryExceptions. In the version, the buffer's size is created with a uint32_t, fixing the exceptions.