Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement menu to support custom topic names #93

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

juanlofer-eprosima
Copy link
Contributor

See #88

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (445b11a) 20.61% compared to head (8efab44) 21.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   20.61%   21.06%   +0.44%     
==========================================
  Files          28       28              
  Lines        2561     2564       +3     
  Branches     1304     1304              
==========================================
+ Hits          528      540      +12     
+ Misses       1589     1567      -22     
- Partials      444      457      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
rsanchez15
rsanchez15 previously approved these changes Nov 17, 2023
@rsanchez15 rsanchez15 dismissed their stale review November 17, 2023 11:27

Missing docs

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@juanlofer-eprosima juanlofer-eprosima merged commit 7b678b9 into main Nov 17, 2023
17 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the feature/figure/support-custom-topic-names branch November 17, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants