Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both fastcdr v1 and v2 [19996] #96

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Support both fastcdr v1 and v2 [19996] #96

merged 4 commits into from
Dec 29, 2023

Conversation

richiware
Copy link
Member

No description provided.

@richiware richiware changed the title Support both fastcdr v1 and v2 Support both fastcdr v1 and v2 [19996] Nov 22, 2023
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 291 lines in your changes are missing coverage. Please review.

Comparison is base (7b8e279) 19.80% compared to head (3d93b55) 19.63%.

Files Patch % Lines
...common/types/DynamicTypesCollectionPubSubTypes.cpp 18.00% 32 Missing and 9 partials ⚠️
...ypes/DdsRecorderStatus/DdsRecorderStatusCdrAux.ipp 0.00% 39 Missing ⚠️
...es/DdsRecorderCommand/DdsRecorderCommandCdrAux.ipp 0.00% 33 Missing ⚠️
.../DdsRecorderStatus/DdsRecorderStatusTypeObject.cxx 0.00% 29 Missing ⚠️
...sRecorderCommand/DdsRecorderCommandPubSubTypes.cxx 0.00% 27 Missing ⚠️
...DdsRecorderStatus/DdsRecorderStatusPubSubTypes.cxx 0.00% 27 Missing ⚠️
.../cpp/common/types/DynamicTypesCollectionCdrAux.ipp 62.31% 5 Missing and 21 partials ⚠️
...dsRecorderCommand/DdsRecorderCommandTypeObject.cxx 0.00% 25 Missing ⚠️
...common/types/DynamicTypesCollectionPubSubTypes.hpp 0.00% 12 Missing ⚠️
...DdsRecorderCommand/DdsRecorderCommandPubSubTypes.h 0.00% 6 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   19.80%   19.63%   -0.17%     
==========================================
  Files          29       32       +3     
  Lines        2717     2831     +114     
  Branches     1426     1499      +73     
==========================================
+ Hits          538      556      +18     
- Misses       1723     1782      +59     
- Partials      456      493      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: tempate <danieldiaz@eprosima.com>
@Tempate Tempate merged commit 824e664 into main Dec 29, 2023
17 checks passed
@Tempate Tempate deleted the future/v2.12.1 branch December 29, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants