Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #20419: Fix TypeIdentifier comparation in TypeObject tests. #297

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

adriancampo
Copy link
Contributor

@adriancampo adriancampo commented Feb 12, 2024

Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be above hotfix/typeobjectpair-api and it should update the DDS Types Test submodule to feature/typeidentifier_comparator so the regression tests are included.

@adriancampo adriancampo force-pushed the bugfix/typeidentifier_comparator branch from 0bc433c to 2141f05 Compare February 12, 2024 15:18
@adriancampo adriancampo changed the base branch from feature/xtypes_typeobject to hotfix/typeobjectpair-api February 12, 2024 15:19
Comment on lines +713 to +716
EXPECT_TRUE(compare_type_identifiers(member_type_ids.type_identifier1(), type_objects.minimal_type_object.minimal().struct_type().member_seq()[pos].common().member_type_id()) ||
compare_type_identifiers(member_type_ids.type_identifier1(), type_objects.complete_type_object.complete().struct_type().member_seq()[pos].common().member_type_id()));
EXPECT_TRUE(compare_type_identifiers(member_type_ids.type_identifier2(), type_objects.minimal_type_object.minimal().struct_type().member_seq()[pos].common().member_type_id()) ||
compare_type_identifiers(member_type_ids.type_identifier2(), type_objects.complete_type_object.complete().struct_type().member_seq()[pos].common().member_type_id()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issue is probably going to be happening with union members. Would you mind adding a test case and checking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in 1992c80

@EduPonz EduPonz added this to the v4.0.0 milestone Feb 15, 2024
@JLBuenoLopez JLBuenoLopez force-pushed the hotfix/typeobjectpair-api branch from 519f368 to 1c47438 Compare February 15, 2024 11:13
@JLBuenoLopez JLBuenoLopez force-pushed the hotfix/typeobjectpair-api branch from 1c47438 to 6ff469d Compare February 27, 2024 10:15
@adriancampo adriancampo force-pushed the bugfix/typeidentifier_comparator branch 5 times, most recently from e489ef7 to 1992c80 Compare March 25, 2024 11:48
@JLBuenoLopez JLBuenoLopez force-pushed the hotfix/typeobjectpair-api branch from 6ff469d to b0c34f2 Compare March 26, 2024 10:32
@adriancampo adriancampo force-pushed the bugfix/typeidentifier_comparator branch from 1992c80 to 1fa1435 Compare March 27, 2024 09:06
richiware and others added 15 commits March 28, 2024 14:06
* Refs #19451. Support new fastdds naming

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451. Fix in swig cmake files

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
* Refs #19452: Run Fast DDS Gen CI on PRs to 4.0.x-devel

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19452: Refactor CI

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19452: Fix input

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19452: Fix base branch decision making

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19452: Select correct branches of the other repos

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19452: Correctly fetch specified Fast CDR version

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20640: Tmp disable ccache

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Revert "Refs #20640: Tmp disable ccache"

This reverts commit 0927df5.

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
* Refs #20566: Change headers md5.h and SerializedPayload.h from fastrtps tp fastdds

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Change header fixed_size_string

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20566: Change fixed_size_string namespace from fastrtps to fastcdr

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>

---------

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
* Refs #19944. Initial -genapi

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19944. Remove default templates

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19944. Update scope when getting typecodes

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19944. Fix compilation error

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19944. Apply suggestions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
…ember (#262)

* Refs #19932: update IDL parser submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19932: changes required from review suggestion in IDL Parser

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19932: update submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs #19971. Remove -cdr argument

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19971. Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
* Refs #19960. Implementation

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19960. New argument -no-typesupport

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19960. Remove old template

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19960. New configuration to set explicitly using modules in stg

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19960. Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19960. Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
* Refs #20003. Fix warnings.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20003: do not generate empty namespaces

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20003. Fix warnings and new ReturnCode_t

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs #20052: fix tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20052: update submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs #20056. Argument to change max size of unbounded containers

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20056. Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
* Refs #19837: fix Clang warning, unused lambda capture

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19837: update dds types test submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs #20063. Support for C++ enum class

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20063. Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20063. Update submodule and use Context

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20063. Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
* Refs #20070. Using includes which will be used

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20070. Fix enum casting

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20070. Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
* Refs #20070. Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20070. Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
adriancampo and others added 8 commits April 1, 2024 11:24
…ddsgen (#275)

* Added dds to the list of IDL module replacements

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Added -no-dependencies option to avoid generating files for dependencies

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Apply suggestions from code review

Co-authored-by: Ricardo González <ricardo@richiware.dev>
Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Use constants for arguments

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Fixed args sorting

Signed-off-by: adriancampo <adriancampo@eprosima.com>

---------

Signed-off-by: adriancampo <adriancampo@eprosima.com>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
* Typeobjects with tests (#255)

* Fix tests for common struct name in different modules (#268)

* Refs #20052: fix tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20052: update submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Added TypeObject tests with templates for primitives and strings structures.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Added TypeObject tests for most cases.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Added TypeObject tests for unions enums and annotations.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Added missing checks

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* API changes. Additional checks.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Changes if TypeIdentifiers checks.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* API changes. Fixed errors.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Tests use gtest now.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Format changes.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Fixed namespaces, inheritance check and type functions.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Typo

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Refs #19595: -typeobject argument is deprecated. TypeObject files will always be generated

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix copyright and include header order. Remove unused headers

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix TypeObjectRegistry::get_type_identifiers call

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix TypeObjectRegistry::get_type_objects call

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: remove const tests: constants do not have TypeObject

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix templates. Remove non-required parameter

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: simplify test templates and include collection and string tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: refactor struct TypeObject test

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: refactor bitset TypeObject test

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: refactor bitset TypeObject tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix enum type TypeObject tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix enum literals TypeObject test

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix bitmask TypeObject tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix type detail annotations checks

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix alias tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix union type TypeObject tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix union member tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: reorder templates. Fixes for string/wstring

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: check Collection TypeIdentifier EquivalenceKind

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix discriminator API according to review suggestion

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: array type tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix map type tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: map type tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix build errors

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: check TypeIdentifier and TypeObject consistency

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: remove non-necessary template attribute

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: member applied annotations check

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: remove non necessary templates. Check already done within consistency methods

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: check dimension/union label

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: add annotation type test

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: w/string type tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: REMOVE: comment TypeObject code in order to build

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: update submodules

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fixes in TypeObject tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: update dds types test submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: update idl parser submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: fix Fast DDS include

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19595: update submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com>
Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: introduce new templates to generate TypeObject code

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: TypeObject header implementation

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: minor fixes

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: move anonymous collection name generator to common code

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: skeleton

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: improve verbatim annotation test. Alias custom annotations should be included only once

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: fix typo

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: alias type implementation

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: struct_type implementation

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: fix sequential member id

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: struct members

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: refactor TypeObjectSupport infrastructure

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: refactor TypeObjectSupport

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: do not execute code in main function

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: assign proper member id with inheritance

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: refactor register struct type

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: fix calling templates with proper parameters

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: annotation impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: enum impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: w/string impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: several fixes in tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: alias impl. Annotation refactor

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: fix get TypeObject template

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: union impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: union member impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: bitset impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: bitmask impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: sequences impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: small refactor to adapt to new throwing API

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: update unbounded collections name

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: arrays impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19906: map impl

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: support for not applied annotations

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: generate TypeObject tests only for main dependency

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix expected flags

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: option to avoid generating type object support files

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: delete legacy TypeObject template

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: integration, fix use of external and other minor bugs/typos

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: test integration: fix unbounded collections, correctly test collections, correctly check TypeIdentifiers, correctly use fixed_string API

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: use variables

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix conflicts after rebase

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: no type support option disables also TypeObject support generation

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix Fast DDS include

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: avoid warning

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: use genapi module conversion in TypeObject templates

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: create register_type_object_representation method in TypeSupport

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix map keys

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: add sequence order check and fixes in map keys and minimal annotation parameters

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: update IDL Parser submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix Windows warnings C4456: declararion hides previous local declaration

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix collection name in case of enum types

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: update IDL Parser submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: fix Windows warning

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: update IDL Parser submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20129: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Co-authored-by: Adrian del Campo <107918259+adriancampo@users.noreply.github.com>
* Refs #20335: fix bounded collections with unbounded elements

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20335: update submodules

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Increase test name uniqueness

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Update dds types tests submodule

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs #20533: Fixed tests for member_id of unions.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Refs #20533: Fix for maps equiv_kind.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Refs #20533: Removed unnecessary checks.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Refs #20533: Updated submodule.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Refs #20533: Added check for id2.

Signed-off-by: adriancampo <adriancampo@eprosima.com>

* Refs #20533: Added check for TK_NONE keys

Signed-off-by: adriancampo <adriancampo@eprosima.com>

---------

Signed-off-by: adriancampo <adriancampo@eprosima.com>
* Refs #19451. Support new fastdds naming

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451. Fix in swig cmake files

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
* Refs #19451. First implementation

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451. Fixes

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451. Remove not needed functions on template

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451. Remove unused template macros

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451.- Fix externals

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451.- Fix fixed_string

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451.- Fix warnings

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451.- Update submodule

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@JLBuenoLopez JLBuenoLopez force-pushed the hotfix/typeobjectpair-api branch from b0c34f2 to 62c85e3 Compare April 2, 2024 08:35
* Refs #20335: fix TypeObjectPair API

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20335: use new Fast DDS headers

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

---------

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Base automatically changed from hotfix/typeobjectpair-api to feature/xtypes_typeobject April 4, 2024 06:59
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
@adriancampo adriancampo force-pushed the bugfix/typeidentifier_comparator branch from 1fa1435 to ba7f9e9 Compare April 4, 2024 07:29
@richiware richiware force-pushed the feature/xtypes_typeobject branch 2 times, most recently from 36e063d to 08dfbb7 Compare April 8, 2024 11:59
Base automatically changed from feature/xtypes_typeobject to 4.0.x-devel April 8, 2024 12:38
Base automatically changed from 4.0.x-devel to master May 16, 2024 07:38
@rsanchez15 rsanchez15 modified the milestones: v4.0.0, v4.0.1 Jul 26, 2024
@rsanchez15 rsanchez15 modified the milestones: v4.0.1, v4.0.2 Sep 5, 2024
@rsanchez15 rsanchez15 modified the milestones: v4.0.2, v4.0.3 Oct 3, 2024
@MiguelCompany MiguelCompany modified the milestones: v4.0.3, v4.0.4 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants