Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22761] Add builtin @feed annotation #435

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Feb 10, 2025

Description

This adds @Feed as a builtin annotation. Will be used to mark interface operations (and their parameters) as feeds.

Note: Tests will be added later to the intermediate branch, but I checked manually that the following IDL is correctly parsed with the changes in this PR:

exception OverflowException
{
};

interface Calculator
{
    long addition(in long value1, in long value2) raises (OverflowException);

    long subtraction(in long value1, in long value2) raises (OverflowException);
	
    @feed long fibonacci_seq(in long n_results) raises (OverflowException);
	
    long sum_all(@feed in long value) raises (OverflowException);

    @feed long accumulator(@feed in long value) raises (OverflowException);
};

Contributor Checklist

  • Commit messages follow the project guidelines.
  • NO: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
    • Tests will be added for the full feature later
  • NO: New feature has been documented/Current behavior is correctly described in the documentation.
    • Documentation will be added for the full feature later
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v4.1.0 milestone Feb 10, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 10, 2025
@MiguelCompany MiguelCompany requested review from richiware and removed request for richiware February 11, 2025 08:27
@MiguelCompany MiguelCompany merged commit 5492e2f into feature/rpc/main Feb 11, 2025
4 of 6 checks passed
@MiguelCompany MiguelCompany deleted the feature/rpc/22761 branch February 11, 2025 15:44
MiguelCompany added a commit that referenced this pull request Feb 13, 2025
* Refs #22761. Add builtin @Feed annotation.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #22761. Add auxiliary STG utilities to Operation class.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #22761. Add auxiliary STG utilities to Param class.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants