Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to conditional PUT for branch updates #755

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

paraseba
Copy link
Collaborator

We no longer do the sequence of write-only branch versions.

We no longer do the sequence of write-only branch versions.
Copy link
Contributor

@mpiannucci mpiannucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. We need gcs test but I can do that after this is in

@paraseba paraseba merged commit 9f51c85 into main Feb 20, 2025
5 checks passed
@paraseba paraseba deleted the push-rkowzktysqun branch February 20, 2025 03:17
@@ -560,13 +435,15 @@ mod tests {
mut f: F,
) -> ((Arc<dyn Storage>, R), (Arc<dyn Storage>, R, TempDir)) {
let mem_storage = new_in_memory_storage().await.unwrap();
println!("Using mem storage");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops these snuck in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants