Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #58

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Refactoring #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
4db3882
Prepare not using Cursor
teddychoi Oct 16, 2014
4cab41c
Use Category, not Cursor in feeds API
teddychoi Oct 16, 2014
1d9b750
Extract functions in feeds API
teddychoi Oct 16, 2014
940caf3
Rename API function name. feeds -> list_in_category
teddychoi Oct 16, 2014
5e8efdb
Rename cursor to category
teddychoi Oct 16, 2014
88742c7
Use category in add_feed API
teddychoi Oct 16, 2014
e9fcf4b
Exceptions for errors when adding feed
teddychoi Oct 16, 2014
592b0c0
Function returning subscriptions
teddychoi Oct 16, 2014
0714441
Return empty SubscriptionList when there is None
teddychoi Oct 16, 2014
697ebcf
Get category using subscription list
teddychoi Oct 16, 2014
600b231
Refactoring add_feed API
teddychoi Oct 16, 2014
17994be
Replace Cursor with Category in add_category
teddychoi Oct 16, 2014
58538ff
get_parent_category_id function
teddychoi Oct 16, 2014
68c374e
Replace cursor in delete_category
teddychoi Oct 16, 2014
e6df50a
SubscriptionTransaction to manage subscriptions' change
teddychoi Oct 16, 2014
4922c86
Reset subscriptions when save
teddychoi Oct 16, 2014
6e248e6
Use transaction
teddychoi Oct 16, 2014
f25d822
Replace Cursor with SubscriptionTransaction
teddychoi Oct 16, 2014
105016e
PEP 8
teddychoi Oct 16, 2014
efdb72f
Simplify exception handling when feed not found in category
teddychoi Oct 16, 2014
d1349f3
Add status_code field in JsonException
teddychoi Oct 16, 2014
0aaf199
typo
teddychoi Oct 16, 2014
fa3eec5
Simplify exception handlings
teddychoi Oct 16, 2014
384305d
Use items(), not iteritems()
teddychoi Oct 16, 2014
76320b8
Rename field
teddychoi Oct 20, 2014
8666d0b
Get feed from transaction
teddychoi Oct 20, 2014
28dd713
Update feed through transaction
teddychoi Oct 22, 2014
a2164f6
Revert "Update feed through transaction"
teddychoi Oct 25, 2014
ece5e73
Revert "Revert "Update feed through transaction""
teddychoi Oct 26, 2014
28c9655
Use transaction in request context
teddychoi Oct 26, 2014
bd63b2f
Index page does not need transaction
teddychoi Oct 26, 2014
6d2ec81
Need to check request.method
teddychoi Oct 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading