-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{astro,lib}[foss/2023b] EveryBeam v0.6.1, WSClean v3.5, DP3 v6.2 #21765
{astro,lib}[foss/2023b] EveryBeam v0.6.1, WSClean v3.5, DP3 v6.2 #21765
Conversation
Updated software
|
@boegelbot please test @ generoso |
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2468410804 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ generoso |
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2468471070 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ jsc-zen3 |
@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2468489307 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegelbot |
Test report by @casparvl |
@boegelbot please test @ generoso |
@casparvl: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2468572755 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2607567337 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @casparvl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
FYI, also plenty of succesful builds in EESSI/software-layer#877 |
Test report by @boegel |
@casparvl Is there any way we can avoid relying on Also, it would be great if we didn't rely on on-the-fly downloading durign the installation itself, so this file could be added to |
Wait, where does this get downloaded? |
Ah, found it, in one of the deps https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/c/casacore/casacore-3.5.0-foss-2023b.eb The official instructions say to get it from the FTP server, I have no idea if it would be available in any other way https://github.com/casacore/casacore?tab=readme-ov-file#obtaining-measures-data Can the source step download from FTP? If so, we can definitely do that (would be better, also because then things like Edit: I guess maybe I can do:
or something? |
Fixed in #22201 |
easybuild/easyconfigs/e/EveryBeam/EveryBeam-0.6.1-foss-2023b.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/e/EveryBeam/EveryBeam-0.6.1-foss-2023b.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/e/EveryBeam/EveryBeam-0.6.1-foss-2023b.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/e/EveryBeam/EveryBeam-0.5.4_python_metadata.patch
Outdated
Show resolved
Hide resolved
Co-authored-by: Bob Dröge <b.e.droge@rug.nl>
Test report by @bedroge |
Test report by @bedroge It's picking up Python libraries from the OS. Verified locally that this can be solved by including the change from https://gitlab.com/aroffringa/wsclean/-/commit/46e7d797c9184d67b90b26a38877f91cd07b8e16, and by using the updated CMakeMake easyblock from easybuilders/easybuild-easyblocks#3463. |
…_python_fix Add patch that fixes cmake warning related to boost and python
@boegelbot please test @ jsc-zen3 |
@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2640760861 processed Message to humans: this is just bookkeeping information for me, |
Test report by @bedroge |
Test report by @boegelbot |
Test report by @bedroge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Going in, thanks @casparvl! |
(created using
eb --new-pr
)Created this PR because Rapthor needs a newer
WSClean
, which then in turn needs a newerEveryBeam
. Currently testing a rapthor pipeline to confirm that this combination works - then I'll mark this ready for review.Edit: confirmed to work with Rapthor, so I'd like to get this reviewed and merged :) Note that this requires breaking the one-dep-per-toolchain policy. I'm reasonably sure that these tools are typically used in combination in such pipelines though. Plus: it's the only way to make that particular pipeline work in Rapthor - I believe we find that good enough reason. I'll add exceptions for these CI checks.