Dashboard Pagination (branch→dev) #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
annastasiablack
commented
May 2, 2024
•
annastasiablack
commented
- put timeout on call to users, reduced calls by 3. speeds up loading a tad.
- pagination calls 20 messages on load. arrow button to load next 20 messages. (note: switched to arrows instead of numbers so no unnecessary calls are made)
- tooltip displayed on disabled print buttons to let user know there are no completed forms to print.
…tnl user api calls when loading app.js
dkennedy881
reviewed
May 3, 2024
There was a problem hiding this comment.
Although this does provide the buttons for paginating, the real pagination would limit the results from the the server/ pull x amount. atm this will still attempt to fetch them all. it just wont displays them all at once.
API logic for direct message would also have to get update, involving passing the desired page number and size
annastasiablack
changed the title
dkennedy881
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.