is-online system and agent shouldn't accept arguments #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkemel
force-pushed
the
is-online-agent-arguments
branch
from
68cef3f to
43e3b15
Compare
engelmi
reviewed
Feb 3, 2025
mkemel
force-pushed
the
is-online-agent-arguments
branch
from
43e3b15 to
544c955
Compare
engelmi
approved these changes
Feb 3, 2025
It was found that running `bluechi-is-online agent --monitor 5000 --wait=10000` Does not return error, although `--monitor` is a flag. The reason is that `--monitor` is configured as a flag, and 5000 is treated as an argument, which the method `agent` is configured to accept (min 0, max 2), and the same goes for `system` method. Actually, these two methods do not expect any arguments at all. This change will limit the usage of `bluechi-is-online agent` and `bluechi-is-online system` to not expect arguments, only the allowed options, and `bluechi-is-online node` to accept only one argument Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel
force-pushed
the
is-online-agent-arguments
branch
from
544c955 to
6ec3561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that running
Does not return error, although
--monitoris a flag. The reason is that--monitoris configured as a flag, and 5000 is treated as an argument, which the methodagentis configured to accept (min 0, max 2), and the same goes forsystemmethod. Actually, these two methods do not expect any arguments at all.This change will limit the usage of
bluechi-is-online agentandbluechi-is-online systemto not expect arguments, only the allowed options.