fix: streaming-02-kafka-to-http:fix issues with contract negotiation … #357
Conversation
…and data transfer json requests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'
...sts/src/test/java/org/eclipse/edc/samples/transfer/streaming/Streaming02KafkaToHttpTest.java
Outdated
Show resolved
Hide resolved
...sts/src/test/java/org/eclipse/edc/samples/transfer/streaming/Streaming02KafkaToHttpTest.java
Outdated
Show resolved
Hide resolved
...sts/src/test/java/org/eclipse/edc/samples/transfer/streaming/Streaming02KafkaToHttpTest.java
Outdated
Show resolved
Hide resolved
| assertThat(request).isNotNull(); | ||
| assertThat(request.getBody().readByteArray()).isEqualTo(message.getBytes()); | ||
| }); | ||
| await().atMost(TIMEOUT).untilAsserted(() -> assertThat(LOG_CONSUMER.toUtf8String()).contains(message)); |
There was a problem hiding this comment.
Here I see room for another improvement in the HttpRequestLoggerContainer: I would encapsulate the possibility to get the log into it, so test won't have to deal with this "log consumer" in the tests but just with the container instance.
There was a problem hiding this comment.
Do you want this to be part of this PR? @ndr-brt
Or created as a different issue
There was a problem hiding this comment.
@Juboy different issue will work well
|
Thanks @ndr-brt |
| @@ -12,7 +12,7 @@ runs: | |||
| run: ${{ inputs.command }} | |||
|
|
|||
| - name: Upload Test Results | |||
| uses: actions/upload-artifact@v3 | |||
| uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
in fact this action and the relative "publish test results" job in the verify have been removed so long ago from all the other repos, they can be removed from here as well. Different issue tho :)
…and data transfer json requests
What this PR changes/adds
Issues around running streaming-02-kafka-to-http sample. Issues with contract negotiation and date transfer
Fixed transfer/streaming/streaming-02-kafka-to-http/5-negotiate-contract.json file by including the odrl context.
Fixed transfer/streaming/streaming-02-kafka-to-http/6-transfer.json file by including the transfer type
Why it does that
The contract negotiation was failing because the contract definition was missing the ODRL context, which is required for policy evaluation. Adding the correct ODRL context ensures that contract negotiation can be processed successfully.
Similarly, the transfer process was not working correctly because the transfer type was missing. Including the transfer type explicitly defines the expected data exchange format, allowing the transfer to proceed without errors.
Linked Issue(s)
Closes #339
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.