Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value handling during job step creation #4052

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

MDeLuise
Copy link
Contributor

@MDeLuise MDeLuise commented Jun 7, 2024

Description

This pull request addresses the issue where job step creation does not handle default values correctly. For example, when creating a job step with command execution, if only the commandInput parameter is set and the timeout parameter is left as default, the submission would fail due to the timeout not being set.

Steps to Reproduce

  1. Create a Job.
  2. Create a Job Step with Command Execution.
  3. Try to submit it by setting only the commandInput parameter and leaving timeout as default.
  4. Submit.

Current Behavior

On submission, there is an error due to the timeout not being set.

Expected Behavior

Job step creation should succeed. The JobStepProperties in JobStepDefinition with a propertyValue should be used as a default value for the JobStepProperties in JobStepCreator that haven’t been passed from the user.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.78%. Comparing base (3ddc850) to head (fdf8391).
Report is 21 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4052      +/-   ##
=============================================
+ Coverage      16.67%   16.78%   +0.11%     
  Complexity        22       22              
=============================================
  Files           2008     2006       -2     
  Lines          52134    52089      -45     
  Branches        4409     4384      -25     
=============================================
+ Hits            8691     8745      +54     
+ Misses         43041    42949      -92     
+ Partials         402      395       -7     
Files Coverage Δ
.../service/job/step/internal/JobStepServiceImpl.java 0.00% <0.00%> (ø)

... and 34 files with indirect coverage changes

@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Jun 7, 2024
@Coduz Coduz merged commit 653765d into eclipse-kapua:develop Jun 7, 2024
34 of 35 checks passed
@MDeLuise MDeLuise deleted the fix-jobStepDefaultValues branch June 10, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants