Fix default value handling during job step creation #4052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the issue where job step creation does not handle default values correctly. For example, when creating a job step with command execution, if only the
commandInput
parameter is set and thetimeout
parameter is left as default, the submission would fail due to thetimeout
not being set.Steps to Reproduce
commandInput
parameter and leavingtimeout
as default.Current Behavior
On submission, there is an error due to the
timeout
not being set.Expected Behavior
Job step creation should succeed. The
JobStepProperties
inJobStepDefinition
with apropertyValue
should be used as a default value for theJobStepProperties
inJobStepCreator
that haven’t been passed from the user.