:fix: ScopeId bypass fix #4060
Merged
:fix: ScopeId bypass fix #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tured by the bypass regex for legacy endpoints Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4060 +/- ##
==========================================
Coverage 16.81% 16.81%
Complexity 22 22
==========================================
Files 2008 2008
Lines 52113 52113
Branches 4387 4387
==========================================
Hits 8763 8763
Misses 42957 42957
Partials 393 393
|
Coduz
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A scopeId can contain dashes. On some rest endpoints, to maintain the legacy (deprecated) representation that accepted (and then ignored) the scopeId as the first part of the url, the regex \w+ has been used - however that covers MOST of the characters that can appear in a ScopeId, except the dash. This pr fixes that.