🐛 Avoid multiple GuiceLocator instances, and handle potential multiple KapuaMessageListeners #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4066 +/- ##
=============================================
- Coverage 16.79% 16.78% -0.01%
Complexity 22 22
=============================================
Files 2008 2008
Lines 52210 52229 +19
Branches 4399 4401 +2
=============================================
- Hits 8770 8768 -2
- Misses 43044 43064 +20
- Partials 396 397 +1
|
dseurotech
force-pushed
the
fix-avoid_multiple_MessageListeners
branch
from
4f884aa to
54c7ae6
Compare
…Kapua)MessageListenr are istantiated, failing device login due to split map Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
dseurotech
force-pushed
the
fix-avoid_multiple_MessageListeners
branch
from
54c7ae6 to
fae4a63
Compare
Coduz
approved these changes
Jul 8, 2024
riccardomodanese
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should guicelocator fail at broker startup, multiple instances of (Kapua)MessageListener are istantiated, failing device login due to split request/response maps.
In general, guice modules should avoid doing logic, and should avoid failing. Guice cannot guarantee that singleton objects previously instantiated are killed - which in some cases can be very distruptive.
This pr both avoids multiple guiceLocator instantiation attempts within a single process, but also puts in place safeguards that ensure that message correlation will continue to work even if there are multiple (Kapua)MessageListener (possibly due to changes in the wiring).