Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Console GWT] Fixed Credential Edit dialog does not letting update the selected Credential #4085

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jul 22, 2024

This PR fixes the editing of the a Credential from the web admin Console which is currently never enabling the submit button.

Related Issue
This PR fixes/closes {issue number}

Description of the solution adopted
Hide and disabled fields that are not editable from the User in the Edit Dialog

Screenshots
None

Any side note on the changes made
None

…the selected Credential

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console labels Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.79%. Comparing base (70cbdd3) to head (7694759).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4085   +/-   ##
==========================================
  Coverage      16.79%   16.79%           
  Complexity        22       22           
==========================================
  Files           2016     2016           
  Lines          52317    52317           
  Branches        4407     4407           
==========================================
  Hits            8787     8787           
  Misses         43132    43132           
  Partials         398      398           

@Coduz Coduz changed the title 🐛 [Cosnole GWT] Fixed Credential Edit dialog does not letting update the selected Credential 🐛 [Console GWT] Fixed Credential Edit dialog does not letting update the selected Credential Jul 22, 2024
@Coduz Coduz merged commit 6659768 into eclipse-kapua:develop Jul 22, 2024
34 checks passed
@Coduz Coduz deleted the fix-credentialNotEditableFromConsole branch July 22, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant