Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optional positional embedding in processor #57

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sahahner
Copy link
Member

@sahahner sahahner commented Jan 2, 2025

At the moment the latitude and longitude coordinates of the grid points are provided to the encoder only.

This PR implements the positional embedding for that transformer in the processor.

Related to this issue: https://github.com/ecmwf/aifs-dev/issues/10

Resolved points from anemoi-models PR

  • shape of positional embedding flexible
  • make use of positional embedding more flexible. use hydra instantiation
    Lat, Cos(lon), Sin(lon)
    Cos(lat), Sin(lat), Cos(lon), Sin(lon)

@sahahner sahahner changed the title Models feature/positional embedding hidden grid Implement optional positional embedding in processor Jan 2, 2025
@sahahner sahahner self-assigned this Jan 2, 2025
Copy link
Member

@HCookie HCookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need some updates to work with the recent pydantic changes, but apart from that LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants