ECC-1722: API: Allow setting integer key as missing via codes_set_string

ecmwf · Nov 20, 2023 · 2d128f5 · 2d128f5
1 parent ddc1d47
commit 2d128f5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/examples/C/grib_set_missing.c b/examples/C/grib_set_missing.c
@@ -59,6 +59,10 @@ int main(int argc, char** argv)
     CODES_CHECK(codes_set_missing(h, "scaleFactorOfFirstFixedSurface"), 0);
     CODES_CHECK(codes_set_missing(h, "scaledValueOfFirstFixedSurface"), 0);
 
+    /* Can also set to MISSING via codes_set_string */
+    CODES_CHECK(codes_set_string(h, "scaleFactorOfFirstFixedSurface", "missing", &str_len), 0);
+    CODES_CHECK(codes_set_string(h, "scaledValueOfFirstFixedSurface", "missing", &str_len), 0);
+
     /* see GRIB-490 */
     CODES_CHECK(codes_get_long(h, "Ni", &Ni), 0);
     is_missing = codes_is_missing(h, "Ni", &err);

diff --git a/src/grib_accessor_class_long.cc b/src/grib_accessor_class_long.cc
@@ -257,10 +257,10 @@ static int pack_string(grib_accessor* a, const char* val, size_t* len)
 {
     long v = 0; /* The converted value */
 
-    // Requires more work e.g. filter
-    //if (strcmp_nocase(val, "missing")==0) {
-    //    return pack_missing(a);
-    //}
+    // ECC-1722
+    if (strcmp_nocase(val, "missing")==0) {
+        return pack_missing(a);
+    }
 
     if (string_to_long(val, &v, 1) != GRIB_SUCCESS) {
         grib_context_log(a->context, GRIB_LOG_ERROR,