Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECC-2008: Action hierarchy: Use C++ inheritance mechanism #283

Merged
merged 16 commits into from
Jan 20, 2025

Conversation

joobog
Copy link
Collaborator

@joobog joobog commented Jan 17, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 86.40054% with 201 lines in your changes missing coverage. Please review.

Project coverage is 87.41%. Comparing base (0e88697) to head (7b916c9).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/action/action_class_write.cc 74.64% 18 Missing ⚠️
src/action/action.h 16.66% 15 Missing ⚠️
src/action/action_class_if.cc 88.28% 15 Missing ⚠️
src/action/action_class_switch.cc 84.53% 15 Missing ⚠️
...rc/accessor/grib_accessor_class_bufr_data_array.cc 78.33% 13 Missing ⚠️
src/action/action_class_assert.cc 69.04% 13 Missing ⚠️
src/action/action_class_set_darray.cc 51.85% 13 Missing ⚠️
src/action/action_class_set_sarray.cc 51.85% 13 Missing ⚠️
src/action/action_class_list.cc 82.25% 11 Missing ⚠️
src/action/action_class_hash_array.cc 91.75% 8 Missing ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #283      +/-   ##
===========================================
- Coverage    87.44%   87.41%   -0.04%     
===========================================
  Files          833      835       +2     
  Lines        62037    61797     -240     
  Branches     11044    11015      -29     
===========================================
- Hits         54250    54018     -232     
+ Misses        7787     7779       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn changed the title Conversion of actions to C++ ECC-2008: Action hierarchy: Use C++ inheritance mechanism Jan 20, 2025
@shahramn shahramn self-assigned this Jan 20, 2025
@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Jan 20, 2025
@shahramn shahramn merged commit 9128130 into develop Jan 20, 2025
177 of 180 checks passed
@shahramn shahramn deleted the feature/modernisation_action_const_destr branch January 20, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants