Order shape elements before decoding #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since Edit: fixed (for shapes) with Handle sub-args in Queryable for structs |
|
Closes #285 |
aljazerzen
force-pushed
the
order-shape-elements
branch
from
22de18c to
79694a8
Compare
msullivan
approved these changes
Feb 4, 2025
|
Yeah. All macro code I've written is like that. Not saying that it cannot be different, I'm realizing that maybe I should do something about it. Comments are a good start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so
Queryableon structs does not require the struct to have the same order of fields as the shape elements in the EdgeQL query.This is done by capturing the order of the shape elements in
check_descriptorand then applying that order indecode.