Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add formatting checks. #3

Merged
merged 2 commits into from
Jun 12, 2024
Merged

CI: Add formatting checks. #3

merged 2 commits into from
Jun 12, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Jun 11, 2024

Add an sbt plugin for scalafmt, enabling to run sbt scalaFmtAll to autoformat the whole project.
Add a root .scalafmt.conf for (default at this point) format configuration.
Add a CI check that all code respect this format - we can configure it progressively If we dislike anything.

Intent:

  • decouples any formatting discussion from any feature/code addition
  • Get consistent and at least relatively clear format, always, with no (format-related... 😉) headaches

I'm fine waiting to merge this if this is annoying to anyone. VSCode has nice support for this, where you can autoformat using the config on save, happy to document if this helps anyone

@PapyChacal PapyChacal requested a review from baymaks June 11, 2024 19:41
@PapyChacal PapyChacal self-assigned this Jun 11, 2024
Copy link
Collaborator

@baymaks baymaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@baymaks baymaks merged commit b0c30eb into main Jun 12, 2024
2 checks passed
@baymaks baymaks deleted the emilien/scalafmt branch June 12, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants