Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First Implementation of the Printer & Successors :) #5

Merged
merged 14 commits into from
Jun 20, 2024
Merged

First Implementation of the Printer & Successors :) #5

merged 14 commits into from
Jun 20, 2024

Conversation

baymaks
Copy link
Collaborator

@baymaks baymaks commented Jun 14, 2024

No description provided.

PapyChacal
PapyChacal reviewed Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds about right so far!
Let's add test 😋

I would remove the commented classes above the print functions before merging even the first time here; those have a nasty habit of staying around and getting out of sync if the actual classes change!

@baymaks baymaks changed the title First Implementation of the Printer First Implementation of the Printer & Successors :) Jun 19, 2024
@baymaks baymaks merged commit 391e9d8 into main Jun 20, 2024
2 checks passed
@baymaks baymaks deleted the maks-branch2 branch June 20, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PapyChacal PapyChacal PapyChacal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baymaks @PapyChacal