Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yang et al. (2016) reproduction #198

Merged
merged 1 commit into from
May 2, 2018
Merged

Conversation

edoddridge
Copy link
Owner

Now that Aronnax supports outcropping, it is possible to perform simulations similar to those from Yang et al. (2016), making progress on #60 (though this paper wasn't listed because it required outcropping).

This PR introduces a new example that is similar to their control run. However, the agreement between Aronnax and their simulation is somewhat disappointing - the mean state is noticeably different. Having gone to the effort of creating and running the simulation, I think it's worth including despite the disappointing lack of agreement. It's also a nice demonstration of Aronnax's n-layer capabilities and provides a "research ready" example for future users to hack.

In the new section of documentation I mention that the results are different, and speculate on the numerical differences that might be responsible. I've also included some fancy visualisations and animations in the documentation for this example, which are potential candidates for #94 and make progress on #38.

@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #198 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #198      +/-   ##
=========================================
+ Coverage   90.38%   90.5%   +0.12%     
=========================================
  Files          19      19              
  Lines        1570    1570              
  Branches       82      82              
=========================================
+ Hits         1419    1421       +2     
+ Misses        124     123       -1     
+ Partials       27      26       -1
Impacted Files Coverage Δ
src/model_main.f90 95.65% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a636218...64c07dc. Read the comment docs.

@edoddridge edoddridge merged commit 4ad8dda into master May 2, 2018
@edoddridge edoddridge deleted the Yang-reproduction branch May 2, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant