Add Yang et al. (2016) reproduction #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Aronnax supports outcropping, it is possible to perform simulations similar to those from Yang et al. (2016), making progress on #60 (though this paper wasn't listed because it required outcropping).
This PR introduces a new example that is similar to their control run. However, the agreement between Aronnax and their simulation is somewhat disappointing - the mean state is noticeably different. Having gone to the effort of creating and running the simulation, I think it's worth including despite the disappointing lack of agreement. It's also a nice demonstration of Aronnax's n-layer capabilities and provides a "research ready" example for future users to hack.
In the new section of documentation I mention that the results are different, and speculate on the numerical differences that might be responsible. I've also included some fancy visualisations and animations in the documentation for this example, which are potential candidates for #94 and make progress on #38.