Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red grav bot drag #243

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Red grav bot drag #243

merged 2 commits into from
Nov 16, 2022

Conversation

edoddridge
Copy link
Owner

Add bottom drag to reduced gravity simulations with an active lower layer.

Added code to allow this feature, and a test to make sure it works as expected.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #243 (f8459a4) into master (2424b32) will decrease coverage by 0.31%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   74.41%   74.10%   -0.32%     
==========================================
  Files          20       20              
  Lines        1419     1425       +6     
  Branches       85       89       +4     
==========================================
  Hits         1056     1056              
- Misses        313      315       +2     
- Partials       50       54       +4     
Impacted Files Coverage Δ
src/momentum.f90 66.43% <40.00%> (-2.91%) ⬇️
src/state_deriv.f90 80.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@edoddridge
Copy link
Owner Author

The code coverage metrics are still wrong :(
See #242 for details.

The new code is tested by a new test in physics_tests.py, since the effect of linear bottom drag can be easily predicted analytically.

Since all other tests pass, I'm going to merge this.

@edoddridge edoddridge merged commit 6cd1727 into master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant