Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: sumac release support AP-1582 #74

Merged
merged 7 commits into from
Nov 28, 2024
Merged

perf: sumac release support AP-1582 #74

merged 7 commits into from
Nov 28, 2024

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Nov 20, 2024

Description

This PR adds support for the Open edX Sumac release.

These were the changes made:

  • Upgraded requirements based on the edx-platform Sumac release.
  • Updated the Integration Tests to use the Sumac release with Tutor.

Testing instructions

  1. Create an environment with Sumac release, you can use Tutor or TVM.

  2. Install and enable tutor-contrib-picasso.

  3. Install and enable tutor-mfe.

  4. Add the following settings in your config.yml:

    PICASSO_DEFAULT_SITE_THEME: test-1
    PICASSO_EOX_THEMING_DPKG:
      name: eox-theming
      repo: 'git@github.com:eduNEXT/eox-theming.git'
      version: bav/sumac-support
    PICASSO_THEMES:
      - name: ednx-test-themes
        repo: 'git@github.com:eduNEXT/ednx-test-themes.git'
        version: master
    PICASSO_THEMES_NAME:
      - test-1
      - test-2
      - test-3
    PICASSO_THEMES_ROOT: /openedx/themes
    PICASSO_THEME_DIRS:
      - /openedx/themes/ednx-test-themes/edx-platform
  5. Clone the test themes folder with tutor picasso enable-themes

  6. Add the testing themes running and init the environment with tutor dev launch

  7. Create a new tenant and add this settings to the tenant configs:

    {
        "EDNX_USE_SIGNAL": true,
        "ENABLE_ACCOUNT_MICROFRONTEND": false,
        "ENABLE_AUTHN_MICROFRONTEND": false,
        "PLATFORM_NAME": "Tenant A",
        "SITE_NAME": "tenant-a.local.openedx.io:8000",
        "THEME_OPTIONS": {
            "scripts": {
                "/login": [
                    {
                        "content": "alert('This is a test for the inline script');",
                        "type": "inline"
                    }
                ]
            },
            "theme": {
                "grandparent": "test-3",
                "name": "test-1",
                "parent": "test-2"
            }
        },
        "course_org_filter": [
            "TenantA"
        ],
        "footer_override": "<div style=\"width: 100%;\"><div style=\"position: relative; padding-bottom: 41.67%; padding-top: 0; height: 0;\"><iframe title=\"Footer X\" frameborder=\"0\" width=\"1200\" height=\"500\" style=\"position: absolute; top: 0; left: 0; width: 100%; height: 100%;\" src=\"https://view.genially.com/66464d3334225f0015c0dc0e\" type=\"text/html\" allowscriptaccess=\"always\" allowfullscreen=\"true\" scrolling=\"yes\" allownetworking=\"all\"></iframe> </div> </div>",
        "header_langselector": true,
        "header_links": [
            {
                "target": "_self",
                "txt": "Courses",
                "url": "/courses"
            },
            {
                "class": "mx-2",
                "target": "_self"
            }
        ],
        "released_languages": "en,vi,es-419"
    }
  8. Go to your admin panel and edit the learner_home_mfe.enabled Waffle Flag with the property Everyone in No to disable the Authn MFE.

  9. Run the test cases. In this file, you can find more information about the plugin configuration.

Related Issues

@BryanttV BryanttV marked this pull request as ready for review November 22, 2024 16:32
@BryanttV BryanttV requested a review from a team as a code owner November 22, 2024 16:32
@magajh
Copy link
Contributor

magajh commented Nov 26, 2024

@BryanttV has this been tested in a remote env?

@BryanttV
Copy link
Contributor Author

Hi @magajh, Yes, these changes were tested in our Sumac remote environment.

magajh
magajh previously approved these changes Nov 27, 2024
Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I haven't had time to replicate the test cases, but if we are sure this works in remote then LGTM

@magajh
Copy link
Contributor

magajh commented Nov 28, 2024

@BryanttV have we tested that the integration tests for Redwood are successful?

Copy link

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BryanttV BryanttV merged commit 33bc6af into master Nov 28, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants