-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.8 and replace pkg_resources with importlib.resources #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luisfelipec95, a couple of things that we still need to do in this PR:
- Remove the
backports.zoneinfo
constraint https://github.com/eduNEXT/eox-theming/blob/master/requirements/constraints.txt#L14 - Update the compatibility table since this new version is no longer compatible with Quince https://github.com/eduNEXT/eox-theming/tree/master?tab=readme-ov-file#compatibility-notes. We should also mention that we lose compatibility with Quince release in the Changelog
- Can you please also review and merge this PR? chore(deps): bump pypa/gh-action-pypi-publish from 1.12.2 to 1.12.4 #80
I've checked our site in stage, and the theming looks fine. I haven't had time to thoroughly test it, but if you and @DeimerM have tested it in stage and are sure it's working, then I'm okay with it
Co-authored-by: Maga Giorgianni <maria.jaimes@edunext.co>
Co-authored-by: Maga Giorgianni <maria.jaimes@edunext.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment, everything else LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
pkg_resources (from setuptools) is deprecated and will be removed in future Python versions.
The new implementation uses importlib.resources, which is the recommended alternative and is fully available in Python 3.9+.
Testing instructions
Create an environment with Sumac release, you can use Tutor or TVM.
Install and enable tutor-contrib-picasso.
Install and enable tutor-mfe.
Add the following settings in your
config.yml
:Clone the test themes folder with
tutor picasso enable-themes
Add the testing themes running and init the environment with
tutor dev launch
Create a new tenant and add this settings to the tenant configs:
Go to your admin panel and edit the
learner_home_mfe.enabled
Waffle Flag with the propertyEveryone
inNo
to disable the Authn MFE.Run the test cases. In this file, you can find more information about the plugin configuration.
Other Information
openedx/public-engineering#273